Github user jeanlyn closed the pull request at:
https://github.com/apache/spark/pull/5079
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-85085332
After communicated with @adrian-wang offline. I realized this PR still
leave some class loader problem.So i close this one.
---
If your project is set up for it, you
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83359940
The tests in 2 PRs are different, this PR is about the UDF jar, but #4586
is the SerDe jar. They may be loaded by difference class loader.
@jeanlyn can
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83372666
@jeanlyn we are not getting same thing. Even our .q file differs. I don't
have CHAR in my .q file.
---
If your project is set up for it, you can reply to this email
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83372419
@chenghao-intel my full code is
```java
import org.apache.hadoop.hive.ql.exec.UDF;
public class hello extends UDF {
public String evaluate(String
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83383402
I also don't have CHAR in `mapjoin_addjar.q`. I only find one
`mapjoin_addjar.q`,and the path of my file is
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82908034
Updated, @liancheng @marmbrus I had tried to add a test for this
patch,could you take a look for the test?
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82888519
[Test build #28792 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28792/consoleFull)
for PR 5079 at commit
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82976538
Ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82967018
Hm, the problem is that we should also add the source code of `hello.jar`
(probably after renaming it to `TestUdf.jar`). But I'm not quite sure where to
put it for
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82935967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82935924
[Test build #28792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28792/consoleFull)
for PR 5079 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82972253
Your test case itself makes sense. Let's wait for more comments first :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82970359
Thanks @liancheng for explain.You are right,it need consider more about
it.So,should i remove the test?
---
If your project is set up for it, you can reply to this
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83039875
Will it be better if we put the jar in
`sql/hive-thriftserver/src/test/resources/jar` (not in `data`)? Also, what is
in that jar? A hello world function?
---
If your
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82798459
@marmbrus We can merge this PR first, I'm trying to write a test case for
this PR.
---
If your project is set up for it, you can reply to this email and have your
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83254407
@yhuai ,There is a simple functions
```java
public String evaluate(String str) {
try {
return hello + str;
} catch
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83252541
[Test build #28849 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28849/consoleFull)
for PR 5079 at commit
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83265743
Same issue with #4586 ? Actually we are quite headache with the class
loading/unloading problem. @adrian-wang can you review this also?
---
If your project is
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83267913
@chenghao-intel I am not clear what problem #4586 try to fix.If #4586 try
to fix the problem as I mentioned.I think we can reuse the
`SparkContext.addJar` is enough to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83281487
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83281417
[Test build #28849 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28849/consoleFull)
for PR 5079 at commit
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83299775
@adrian-wang You mean not work in `spark-shell` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83348085
@adrian-wang ,I had tested in `spark-sql` ,and get result correctly with my
test case. Can you provide your test case?By the way,when i debug this issue i
found in the
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83349543
@jeanlyn you can just try execute ` mapjoin_addjar.q` in `spark-sql`.
Note you need to find a valid jar position.
---
If your project is set up for it, you can
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83312186
@jeanlyn have you tried clean assembly and run it in `spark-sql`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83329608
I double checked your code with latest master, the problem still persists.
Considered this is just a dup of #4586 maybe we should close this one.
Thanks!
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-83275475
Actually I tried this method before and it would work in unit test but not
ok with shell.
I'll double check this in the afternoon.
---
If your project is set up
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82730032
[Test build #28764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28764/consoleFull)
for PR 5079 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82730035
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user jeanlyn opened a pull request:
https://github.com/apache/spark/pull/5079
[SPARK-6392][SQL]Minor fix ClassNotFound exception when use spark cli to
add jar
When we use spark cli to add jar dynamic,we will get the
`java.lang.ClassNotFoundException` when we use the class
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82695190
Would it be possible to add a test case in the CLI suite? /cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82695129
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82689590
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5079#issuecomment-82697008
[Test build #28764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28764/consoleFull)
for PR 5079 at commit
35 matches
Mail list logo
