Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34179089
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34179618
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34183085
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34183255
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34184040
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foun
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-119696997
If you `collect` L112's `frequentLengthOnePatternAndCounts` (after
renaming), L112-129 and L169-183 are basically identical
(`frequentLengthOnePatternAndCounts` <=>
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-119761323
@zhangjiajin The issue with method 2 is projection before filtering. It may
increase the shuffle size. After we generate possible prefixes, we should count
their frequenc
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34214439
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34214527
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34215012
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34215036
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34215138
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34217018
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34217882
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34218011
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34218107
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34220995
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34221305
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34228787
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34228983
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34230322
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34230317
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34230381
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34230466
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34237882
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Found
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34237868
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Found
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34237940
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Found
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34241848
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/fpm/PrefixSpanSuite.scala ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Found
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34242017
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120008278
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120008317
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120009003
[Test build #36933 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36933/consoleFull)
for PR 7258 at commit
[`1dd33ad`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120009392
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120009384
[Test build #36933 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36933/console)
for PR 7258 at commit
[`1dd33ad`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120017949
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120017981
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120020087
[Test build #36935 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36935/consoleFull)
for PR 7258 at commit
[`4c60fb3`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120021942
[Test build #36935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36935/console)
for PR 7258 at commit
[`4c60fb3`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120021960
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120026499
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120026390
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120028906
[Test build #36936 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36936/consoleFull)
for PR 7258 at commit
[`ba5df34`](https://gith
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269643
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269635
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269706
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269648
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269691
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269685
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269678
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269665
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269682
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269688
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269658
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269672
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269652
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120045016
@zhangjiajin Since you already collected the frequent items (length-1
patterns) to driver, you don't need to keep the RDD of length-1 patterns. When
generating the final
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120045530
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120045224
[Test build #36936 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36936/console)
for PR 7258 at commit
[`ba5df34`](https://github.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34269699
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user zhangjiajin commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120057018
@mengxr I don't know why method 2 is projection before filtering. I think
the method two is exactly what you want. The only need to add functionality to
the current
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34333429
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34333437
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34333492
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34333569
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34333634
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34333999
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34334197
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34343241
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34344040
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120394889
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120403966
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120404660
[Test build #37035 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37035/consoleFull)
for PR 7258 at commit
[`574e56c`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120411698
[Test build #37035 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37035/console)
for PR 7258 at commit
[`574e56c`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120411721
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34405125
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/fpm/LocalPrefixSpan.scala ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Fou
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34405150
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/fpm/LocalPrefixSpan.scala ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Fou
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34405364
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/fpm/LocalPrefixSpan.scala ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Fou
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34405371
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/fpm/LocalPrefixSpan.scala ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Fou
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34405622
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34408039
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34408050
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34408256
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/fpm/LocalPrefixSpan.scala ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foun
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34408260
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/fpm/LocalPrefixSpan.scala ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foun
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34408297
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34408322
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34408636
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120564465
@feynmanliang comments: Delete makePrefixProjectedDatabases, move the
groupByKey() to the last call in this method (no need to include the two map()s
on L161 and L16
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34408693
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34408696
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120565046
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120565049
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120565155
[Test build #37073 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37073/consoleFull)
for PR 7258 at commit
[`ca9c4c8`](https://gith
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120565450
@zhangjiajin Yep, you're right. Thanks for pointing it out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120565530
LGTM pending tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120566150
[Test build #37073 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37073/console)
for PR 7258 at commit
[`ca9c4c8`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120566171
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zhangjiajin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7258#discussion_r34409302
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120571131
@zhangjiajin Let's merge this version and make improvements in follow-up
PRs:
1. `LocalPrefixSpan` performance
a. `run` should output `Iterator` instead of
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120571467
Merged into master. Thanks for contributing PrefixSpan!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zhangjiajin commented on the pull request:
https://github.com/apache/spark/pull/7258#issuecomment-120572678
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
1 - 100 of 220 matches
Mail list logo
