Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-89639203
Merging this in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-89629603
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-89604923
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-89172812
The changes mostly lgtm. Let's add the ThreadSafeRpcEndpoint interface for
differentiation.
---
If your project is set up for it, you can reply to this email and have your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-89170592
I like the idea of ThreadSafeRpcEndpoint.
I need to think a little bit more about send/sendWithReply. I do find it
error prone as is.
---
If your project is set u
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27490540
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -92,23 +96,28 @@ private[spark] class CoarseGrainedExecutor
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-88136953
> does send ever throw an exception? what happens to that thread?
`self.send` may throw an IllegalArgumentException, because both `self.send`
and `onStop` may cal
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27490548
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -169,6 +165,11 @@ class CoarseGrainedSchedulerBac
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27490525
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -21,39 +21,43 @@ import java.net.URL
import java.nio.B
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-88135195
There are two things that's worth to review carefully:
1. Calling `setupEndpointRef ` or `setupThreadSafeEndpointRef ` to create
`RpcEndpoint`. When I was doing t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-88111445
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-88111419
[Test build #29481 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29481/consoleFull)
for PR 5268 at commit
[`30a9036`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-88074124
[Test build #29481 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29481/consoleFull)
for PR 5268 at commit
[`30a9036`](https://githu
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27448846
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -91,17 +103,25 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext, sched
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27448418
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerSlaveEndpoint.scala ---
@@ -17,41 +17,43 @@
package org.apache.spark.storage
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-87891855
I took a very quick look at this. @zsxwing If there are any tricky parts,
can you point them out on this pull request to make it easier to review?
---
If your project is se
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27446421
--- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
@@ -91,17 +103,25 @@ private[spark] class HeartbeatReceiver(sc:
SparkContext, schedule
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27446380
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -21,39 +21,43 @@ import java.net.URL
import java.nio.Byte
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27446393
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -21,39 +21,43 @@ import java.net.URL
import java.nio.Byte
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27446365
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -92,23 +96,28 @@ private[spark] class CoarseGrainedExecutorBac
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27446285
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -169,6 +165,11 @@ class CoarseGrainedSchedulerBacken
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27446269
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/local/LocalBackend.scala ---
@@ -87,9 +86,15 @@ private[spark] class LocalActor(
}
if
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27446223
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerSlaveEndpoint.scala ---
@@ -17,41 +17,43 @@
package org.apache.spark.storage
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5268#discussion_r27446180
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerSlaveEndpoint.scala ---
@@ -17,41 +17,43 @@
package org.apache.spark.storage
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-87752511
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-87752494
[Test build #29406 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29406/consoleFull)
for PR 5268 at commit
[`705245d`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5268#issuecomment-87727436
[Test build #29406 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29406/consoleFull)
for PR 5268 at commit
[`705245d`](https://githu
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/5268
[SPARK-6602][Core] Replace direct use of Akka with Spark RPC interface -
part 1
This PR replaced the following `Actor`s to `RpcEndpoint`:
1. HeartbeatReceiver
1. Update ExecutorActor
29 matches
Mail list logo
