Github user yjshen closed the pull request at:
https://github.com/apache/spark/pull/8200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48503308
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
---
@@ -116,13 +110,4 @@ class BooleanSimplific
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48502484
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -464,6 +465,24 @@ object OptimizeIn extends Rule[LogicalP
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166860512
Just realized that [one of the common factor elimination rules][1] defined
in `BooleanSimplification` actually reverts CNF normalization, thus we may
never reach fixed
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48333880
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -464,6 +465,24 @@ object OptimizeIn extends Rule[Logic
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166844885
Made a draft PR #10444 based on the idea described in [another comment of
mine][1] above to workaround exponential expansion issue of CNF normalization.
[1]: h
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48331134
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -464,6 +465,24 @@ object OptimizeIn extends Rule[Logic
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48328448
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -464,6 +465,24 @@ object OptimizeIn extends Rule[Logic
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48289260
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -464,6 +465,24 @@ object OptimizeIn extends Rule[LogicalP
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48227861
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -464,6 +465,24 @@ object OptimizeIn extends Rule[LogicalPla
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48226953
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -464,6 +465,24 @@ object OptimizeIn extends Rule[LogicalPla
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166504555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166504554
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166504503
**[Test build #48156 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48156/consoleFull)**
for PR 8200 at commit
[`91b2c26`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166492262
**[Test build #48156 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48156/consoleFull)**
for PR 8200 at commit
[`91b2c26`](https://gith
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166491984
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166489983
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166489984
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166489952
**[Test build #48154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48154/consoleFull)**
for PR 8200 at commit
[`91b2c26`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166482109
**[Test build #48154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48154/consoleFull)**
for PR 8200 at commit
[`91b2c26`](https://gith
Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166480126
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166479191
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166479193
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8200#discussion_r48183738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -464,6 +465,27 @@ object OptimizeIn extends Rule[Logica
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166322011
@yjshen Welcome back!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166286305
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166286310
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8200#issuecomment-166285933
**[Test build #48111 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48111/consoleFull)**
for PR 8200 at commit
[`7eebf6d`](https://git
28 matches
Mail list logo
