Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5434
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-93117357
I am merging this. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92456712
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92456696
[Test build #30174 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30174/consoleFull)
for PR 5434 at commit
[`be50fc6`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92428758
[Test build #30174 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30174/consoleFull)
for PR 5434 at commit
[`be50fc6`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92423907
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92423905
[Test build #30172 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30172/consoleFull)
for PR 5434 at commit
[`51b792e`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92423613
[Test build #30172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30172/consoleFull)
for PR 5434 at commit
[`51b792e`](https://githu
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92423211
@tdas I fixed as per your suggestion. I also made "startTime" more
readable. Here is the new screenshot:
![streaming](https://cloud.githubusercontent.com/assets/
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92291279
Also, could you make the stats at the top of the page "Waiting batches" and
"Processed batches" links to the corresponding sections? And the names should
be consistent, so p
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92290108
Another points I noticed in the UI, in the `Active Batches (XXX)`, the
value is always = number of batches retained. Its looks like that only that
many batches have complete
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5434#discussion_r28224511
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/AllBatchesTable.scala ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foun
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92098789
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92098783
[Test build #30125 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30125/consoleFull)
for PR 5434 at commit
[`86b5e7f`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-92088256
[Test build #30125 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30125/consoleFull)
for PR 5434 at commit
[`86b5e7f`](https://githu
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/5434#discussion_r28205284
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/AllBatchesTable.scala ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software F
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5434#discussion_r28199117
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/AllBatchesTable.scala ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91736340
[Test build #30060 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30060/consoleFull)
for PR 5434 at commit
[`b248787`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91736362
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91724658
[Test build #30060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30060/consoleFull)
for PR 5434 at commit
[`b248787`](https://githu
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91724400
Rebased on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91677461
LGTM. Though, let me try running this locally and seeing the UI myself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91246879
I added some tests to verify the title titles and column names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5434#discussion_r28042811
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala ---
@@ -189,5 +190,21 @@ private[ui] class StreamingPage(parent: StreamingTa
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5434#discussion_r28042756
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala ---
@@ -189,5 +190,21 @@ private[ui] class StreamingPage(parent: StreamingTa
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91146007
This is great start. But we should be adding unit tests for this. Recently
we have started writing unit tests for UI using selenium. Take a look at how
this is written.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91122700
[Test build #29922 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29922/consoleFull)
for PR 5434 at commit
[`8286a26`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91122724
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91113182
[Test build #29922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29922/consoleFull)
for PR 5434 at commit
[`8286a26`](https://githu
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5434#issuecomment-91113024
cc @tdas and @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/5434
[SPARK-6796][Streaming][WebUI] Add "Active Batches" and "Completed Batches"
lists to StreamingPage
This PR adds two lists, `Active Batches` and `Completed Batches`. Here is
the screenshot:
31 matches
Mail list logo
