[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-07 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r36493358 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -62,111 +100,250 @@ case class SortMergeJoin( }

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-07 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r36493188 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -62,111 +100,250 @@ case class SortMergeJoin( }

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127899918 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127899891 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127900058 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127905246 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127905132 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127905222 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127906184 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127906214 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127906326 [Test build #227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/227/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127906716 [Test build #39844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39844/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127907901 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127907896 [Test build #227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/227/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127908730 [Test build #39844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39844/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127908732 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-128224165 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-128224169 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-128224368 [Test build #39983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39983/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-128239391 [Test build #39983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39983/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-128239606 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127560250 @JoshRosen I've fixed the bug that @jeanlyn mentioned, can you merge this first and then do the following steps in #7904 ? --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127504682 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127505435 [Test build #39678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39678/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127504700 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127508742 [Test build #39678 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39678/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127508758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127513075 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127513516 [Test build #39689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39689/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127513050 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127558998 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127558897 [Test build #39689 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39689/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127713743 We should have a test to guard against reintroduction of the the bug that @jeanlyn mentioned. I find the code here to be really dense and hard to understand,

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-127723655 Also, I think that it might be a little clearer to introduce a separate `SortMergeOuterJoin` operator rather than trying to combine the inner and outer joins into the

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-08-04 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r36238964 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala --- @@ -152,16 +149,14 @@ class JoinSuite extends QueryTest with BeforeAndAfterEach

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126581760 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126581734 [Test build #39159 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39159/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126568863 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126568916 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126569073 [Test build #39159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39159/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126208711 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126208727 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126213811 [Test build #39024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39024/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126218039 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126219170 [Test build #39030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39030/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126219174 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126213835 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126218132 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126218775 [Test build #39030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39030/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126209436 [Test build #39024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39024/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126002674 [Test build #38839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38839/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-12555 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126005211 [Test build #38839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38839/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-126005227 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-29 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-125859852 /bump, do you think that we'll have time to finish this for 1.5.0? /cc @rxin --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-29 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-125860123 Yup I will work on this myself tomorrow based on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-125921405 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-22 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r33010716 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -82,86 +130,169 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-21 Thread jeanlyn
Github user jeanlyn commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32891269 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -82,86 +130,169 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-21 Thread jeanlyn
Github user jeanlyn commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32891271 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -90,13 +90,12 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-21 Thread jeanlyn
Github user jeanlyn commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32891298 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -82,86 +130,169 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113717701 Thanks for updating this; I'll try to take another review pass tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113670190 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113670244 [Test build #35337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35337/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113670198 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113669761 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113690424 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113690410 [Test build #35337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35337/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113408338 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32803889 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -36,46 +36,91 @@ import

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113390868 [Test build #35233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35233/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113390452 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113390374 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113408241 [Test build #35233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35233/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-18 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32802697 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -36,46 +36,91 @@ import

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-18 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32802991 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -36,46 +36,91 @@ import

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-18 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32802825 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -36,46 +36,91 @@ import

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-18 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-113348731 @adrian-wang, I'm planning to take another pass on this pretty soon. At a high level, this patch is in very good shape since most of its code is modeled after other

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-111588668 By the way, to provide a bit of context for why I'm reviewing this PR: I'm working on some optimizations to sorting in Spark SQL which should benefit sort-merge-join,

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32329757 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -84,84 +129,164 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32330738 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -84,84 +129,164 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32330049 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -84,84 +129,164 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32330019 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -84,84 +129,164 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32330289 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -84,84 +129,164 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32327276 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -36,46 +36,91 @@ import

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-111532078 [Test build #34777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34777/consoleFull) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-111531231 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32327674 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -36,46 +36,91 @@ import

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32327932 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -84,84 +129,164 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32327111 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -36,46 +36,91 @@ import

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-111531521 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-111531490 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32337036 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -36,46 +36,91 @@ import

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-111570564 @JoshRosen Thanks for your comments, I will refine the code accordingly. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-111569760 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-111569749 [Test build #34777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34777/console) for PR 5717 at commit

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-06-12 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/5717#discussion_r32338245 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala --- @@ -84,84 +129,164 @@ case class SortMergeJoin(

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-106660912 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7165] [SQL] use sort merge join for out...

2015-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5717#issuecomment-106660922 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

  1   2   >