Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127417954
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r36136113
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,11 +49,29 @@ private[ui] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127417975
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127446476
Tested this out locally and it works fine, so I'm going to merge this to
master and branch-1.5. Thanks for being so patient with the test issues and
review feedback!
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127417719
---
If your project is set up for it, you can reply to
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r36136931
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,11 +49,29 @@ private[ui] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127418777
[Test build #39595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39595/consoleFull)
for PR 7808 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127438050
[Test build #39595 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39595/console)
for PR 7808 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127438081
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127451688
Thanks for your patient review, @JoshRosen @squito
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127438651
weird, I cannot even find the failed test cases
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127408526
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127411211
Test failure looks unrelated. Going to try this out manually in my shell,
then will merge to master and 1.5 if there aren't any more issues. Thanks!
---
If your
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127370167
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127370277
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127370250
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r36115208
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,11 +49,29 @@ private[ui] class
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127363204
Tried this out locally and noticed one minor thing with capitalization of
thread names. Once that's fixed, I'll pull this in for 1.5.
---
If your project is set up
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127370026
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127370429
[Test build #39574 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39574/consoleFull)
for PR 7808 at commit
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127358174
@JoshRosen is it ready to go into branch-1.5, as Reynold just cut the
branch-1.5?
---
If your project is set up for it, you can reply to this email and have your
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r36046842
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,11 +49,29 @@ private[ui] class
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r36046796
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,11 +49,29 @@ private[ui] class
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r36046816
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,11 +49,29 @@ private[ui] class
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127061607
I think the PR description is slightly out-of-date:
sort the threads with the reverse order of their IDs (larger IDs stand
for later threads)
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127062068
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127062074
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127061658
I left one minor comment regarding ascending vs. descending alphabetical
ordering. Aside from that, I think that this looks fine and should be merged
for 1.5.0 since
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127064001
[Test build #39439 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39439/consoleFull)
for PR 7808 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127076431
[Test build #39439 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39439/console)
for PR 7808 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127076450
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-127076484
@JoshRosen I just addressed your comments, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126947952
[Test build #39374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39374/consoleFull)
for PR 7808 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126947889
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126947883
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126955787
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126947628
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126955762
[Test build #39374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39374/console)
for PR 7808 at commit
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126962318
@squito thanks
The test cases passed!
I will continue working on the two features you proposed next week
---
If your project is set up for it, you
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126947842
---
If your project is set up for it, you can reply to
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126948708
I like the latest look! no strong opinion on whether the color difference
is still necessary or not.
---
If your project is set up for it, you can reply to this email
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126842026
sure, I will commit the changes within this PR in weekend
I filed a new JIRA in https://issues.apache.org/jira/browse/SPARK-9516
describing the features
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126842067
maybe I can work on SPARK-9516 next week
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126687471
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126744691
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126745857
[Test build #39222 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39222/consoleFull)
for PR 7808 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126782192
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126781899
[Test build #39222 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39222/console)
for PR 7808 at commit
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126788335
This is really cool!
I have a couple of suggestions. I'm not a designer / UI expert at all, so
feel free to reject these (or to simply push them off for the
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126789433
@squito , these are valuable suggestions! We can have a more
convenient-to-use thread-dumping page!
But let's take more suggestions on whether we shall do it
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126579382
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126579360
**[Test build #39143 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39143/console)**
for PR 7808 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126836136
I think that we could drop the colors or make them more subtle. Sorting by
thread name within the groups also sounds like a nice idea. The other two
features could
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126510176
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126510165
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126512001
yeah, just tell me the color code...The current ones are mostly random
choices...
---
If your project is set up for it, you can reply to this email and have your
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r35929869
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,9 +49,28 @@ private[ui] class ExecutorThreadDumpPage(parent:
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r35929430
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,9 +49,28 @@ private[ui] class ExecutorThreadDumpPage(parent:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126530972
[Test build #39113 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39113/console)
for PR 7808 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126531022
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r35929425
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,9 +49,28 @@ private[ui] class ExecutorThreadDumpPage(parent:
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r35930779
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,9 +49,28 @@ private[ui] class ExecutorThreadDumpPage(parent:
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126511431
Thanks for doing this! This has been a really longstanding UI nit for me,
so I'm really happy to see someone fixing it.
I don't claim to be a designer, so
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r35934770
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,9 +49,28 @@ private[ui] class ExecutorThreadDumpPage(parent:
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126510663
---
If your project is set up for it, you can reply to
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7808#discussion_r35929281
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -49,9 +49,28 @@ private[ui] class ExecutorThreadDumpPage(parent:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126510439
[Test build #39113 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39113/consoleFull)
for PR 7808 at commit
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126554914
---
If your project is set up for it, you can reply to
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126555042
@JoshRosen I just updated the patch and uploaded the screenshot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126555332
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126555344
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7808#issuecomment-126555871
[Test build #39143 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39143/consoleFull)
for PR 7808 at commit
73 matches
Mail list logo
