Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6898
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113601746
@liancheng Thanks for pointing this out, test always come with costs (time
to run), so I'd like delay this until when we really need it. After this patch,
Janino only use
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113598503
Should we also add a REPL test case which uses `HiveContext` to ensure the
isolated classloader plays well with code generation? I know that `HiveContext`
only exists
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113593811
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113593763
[Test build #35276 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35276/console)
for PR 6898 at commit
[`24276d4`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113579301
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113579257
[Test build #35273 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35273/console)
for PR 6898 at commit
[`4ff0457`](https://github.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113569258
@yhuai The UDF will not be part of generated Java code, so Janino doesn't
need to import it. UDF will fallback to call `eval()`, because UDF can not be
presented in Java
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113561591
One question that may not related to this pr. If we define a udf in the
repl (or user use `--jars` add a jar containing a udf) and later when we
generate code at executor
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113555385
[Test build #35276 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35276/consoleFull)
for PR 6898 at commit
[`24276d4`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113554809
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113554836
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113549295
Can we add a test in `ReplSuite` (REPL's tests already has sql core as a
dependency)?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113547778
[Test build #35273 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35273/consoleFull)
for PR 6898 at commit
[`4ff0457`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113547079
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113547114
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113443531
[Test build #933 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/933/console)
for PR 6898 at commit
[`7f5ffbe`](https://github.c
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6898#discussion_r32811387
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -241,12 +236,19 @@ abstract class Code
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113409252
[Test build #933 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/933/consoleFull)
for PR 6898 at commit
[`7f5ffbe`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113407584
[Test build #932 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/932/console)
for PR 6898 at commit
[`7f5ffbe`](https://github.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113406582
[Test build #932 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/932/consoleFull)
for PR 6898 at commit
[`7f5ffbe`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113405078
[Test build #35242 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35242/console)
for PR 6898 at commit
[`7f5ffbe`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113402660
[Test build #35242 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35242/consoleFull)
for PR 6898 at commit
[`7f5ffbe`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113402450
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6898#issuecomment-113402413
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/6898
[SPARK-8461] [SQL] fix codegen with REPL class loader
The ExecutorClassLoader for REPL will cause Janino failed to find class for
those in java.lang, so switch to use default class loader for Janino,
26 matches
Mail list logo
