Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-119761660
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-119761749
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-119761730
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7040#discussion_r34211752
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala
---
@@ -296,9 +295,7 @@ case class CaseKeyWhen(key: Expre
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-119761902
[Test build #36862 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36862/consoleFull)
for PR 7040 at commit
[`aac9f67`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-119778674
[Test build #36862 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36862/console)
for PR 7040 at commit
[`aac9f67`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-119778722
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vinodkc commented on a diff in the pull request:
https://github.com/apache/spark/pull/7040#discussion_r34328058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala
---
@@ -296,9 +295,7 @@ case class CaseKeyWhen(key: Expres
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7040#discussion_r34387895
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala
---
@@ -296,9 +295,7 @@ case class CaseKeyWhen(key: Expre
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-120597710
According to the JIRA, if `key` is null, we can just return the else
part(or null if there is no else), right?
I think we can simplify the evaluation logic like
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-120798667
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-120798672
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-120798997
[Test build #37120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37120/consoleFull)
for PR 7040 at commit
[`be5e641`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-120814956
[Test build #37120 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37120/console)
for PR 7040 at commit
[`be5e641`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-120815072
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-121036580
I'm going to merge this to fix the bug. Thanks!
Feel free to do a follow-up to further simplify / optimize.
---
If your project is set up for it, you can reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-121071401
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-121078731
Can you close this please, now that it has been merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vinodkc closed the pull request at:
https://github.com/apache/spark/pull/7040
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
GitHub user vinodkc opened a pull request:
https://github.com/apache/spark/pull/7040
[SPARK-8636][SQL] Fix equalNullSafe comparison
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vinodkc/spark fix_CaseKeyWhen_equalNullSafe
Alte
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-115650672
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user animeshbaranawal commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-115651509
Just changing the loop structure is not sufficient because changing the
loop structure causes the case when tests in ExpressionConditionalSuite to
fail.
---
Github user vinodkc commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-115654691
Ok, I'll update that test suite.
@smola , In predicates.scala, eval method of case class EqualNullSafe has
similar if (l == null && r == null) check , shall I
GitHub user animeshbaranawal opened a pull request:
https://github.com/apache/spark/pull/7044
[SPARK-8636][SQL] Fix equalNullSafe comparison
Referencing pull request #7040
@vinodkc
Can you see the modifications @smola ?
You can merge this pull request into a Git reposit
Github user animeshbaranawal closed the pull request at:
https://github.com/apache/spark/pull/7044
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user animeshbaranawal commented on the pull request:
https://github.com/apache/spark/pull/7040#issuecomment-115656117
Sorry for opening another PR by mistake @vinodkc
Even changing the testsuite alone would not work.
---
If your project is set up for it, you can reply to
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/7040#discussion_r33560845
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala
---
@@ -296,9 +295,7 @@ case class CaseKeyWhen(key: Express
27 matches
Mail list logo
