Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166384678
@hvanhovell I just created
https://issues.apache.org/jira/browse/SPARK-12455 for adding doc. Can you also
put SPARK-12455 in the jira title?
---
If your project is set
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166134999
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166135000
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166134961
**[Test build #48080 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48080/consoleFull)**
for PR 10402 at commit
[`2b806bb`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166127940
**[Test build #48080 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48080/consoleFull)**
for PR 10402 at commit
[`2b806bb`](https://gi
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10402#issuecomment-166127579
jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/10402
[SPARK-8641][SQL] Native Spark Window functions - Follow-up (docs & tests)
This PR is a follow-up for PR https://github.com/apache/spark/pull/9819. It
adds documentation for the window functions
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-166118773
@yhuai & @davies thanks for the reviews!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9819
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-165612187
Thank you @hvanhovell ! I am going to merge it. Let's have a follow-up PR
to add more docs to those newly added functions. Also, can we add tests like
the following?
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47973756
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,281 @@ object SpecifiedWindowF
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47971208
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,281 @@ object SpecifiedWindowFrame
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47971004
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164747726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164747725
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164747581
**[Test build #47726 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47726/consoleFull)**
for PR 9819 at commit
[`c181c8b`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164724290
**[Test build #47726 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47726/consoleFull)**
for PR 9819 at commit
[`c181c8b`](https://gith
Github user 3ourroom commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47621005
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveWindowFunctionQuerySuite.scala
---
@@ -472,7 +475,7 @@ class HiveWin
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47620489
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveWindowFunctionQuerySuite.scala
---
@@ -472,7 +475,7 @@ class HiveW
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164605099
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164605100
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164604963
**[Test build #47685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47685/consoleFull)**
for PR 9819 at commit
[`b4d9ca9`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164589402
**[Test build #47685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47685/consoleFull)**
for PR 9819 at commit
[`b4d9ca9`](https://gith
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164586802
@yhuai I fixed/addressed/improved most of the things you have raised. Two
things worth pointing out:
You can find the test for UDAF here:
https://github.com/
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164586836
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164583021
Build failed due to R versioning problem. I'll try again when this is
sorted out.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164580798
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164580801
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164580690
**[Test build #47676 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47676/consoleFull)**
for PR 9819 at commit
[`b4d9ca9`](https://git
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47565984
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveWindowFunctionQuerySuite.scala
---
@@ -472,7 +475,7 @@ class HiveW
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164558829
**[Test build #47676 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47676/consoleFull)**
for PR 9819 at commit
[`b4d9ca9`](https://gith
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47466167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47465939
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -736,15 +691,148 @@ private[execution] final class
UnboundedFollowing
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47465844
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowF
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47465641
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowF
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47465384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1097,6 +1118,42 @@ class Analyzer(
}
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164359275
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47464485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -120,6 +121,19 @@ sealed trait FrameBoundary {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47464465
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -70,15 +70,32 @@ trait CheckAnalysis {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47464437
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -70,15 +70,32 @@ trait CheckAnalysis {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47464278
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -736,15 +691,156 @@ private[execution] final class
UnboundedFollowingWind
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164313553
@hvanhovell This is very cool! I have finished my review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47453214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -736,15 +691,148 @@ private[execution] final class
UnboundedFollowingWindo
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164312709
Can you add scala doc to explain how we evaluate an regular agg function
when it is used as a window function? (Maybe I missed it)
---
If your project is set up for it, y
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47453068
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47453065
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47453040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164310795
Do we have a test case that uses a UDAF as window function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47452622
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -19,10 +19,13 @@ package org.apache.spark.sql.execution
import o
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47452553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1097,6 +1118,42 @@ class Analyzer(
}
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47452245
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveWindowFunctionQuerySuite.scala
---
@@ -472,7 +475,7 @@ class HiveWindow
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47452210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47452123
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47452110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47451906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47451483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowF
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47450842
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47450253
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowF
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47450230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowF
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47449872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47449863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47449859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47449589
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,238 @@ object SpecifiedWindowFrame
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164284282
@hvanhovell just a quick heads up. I am going to review this PR today. Will
post a comment once I finish my review.
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164169729
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164169728
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164169676
**[Test build #47613 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47613/consoleFull)**
for PR 9819 at commit
[`ba925fe`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-164161849
**[Test build #47613 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47613/consoleFull)**
for PR 9819 at commit
[`ba925fe`](https://gith
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47432910
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -870,26 +878,37 @@ class Analyzer(
//
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47411273
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -736,15 +691,156 @@ private[execution] final class
UnboundedFollowing
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47410438
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -149,43 +152,102 @@ case class Window(
}
/**
-
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47410151
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -736,15 +691,156 @@ private[execution] final class
UnboundedFollowing
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47410028
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -149,43 +152,102 @@ case class Window(
}
/**
- *
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47409455
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -736,15 +691,156 @@ private[execution] final class
UnboundedFollowingWind
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47409043
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -736,15 +691,156 @@ private[execution] final class
UnboundedFollowingWind
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47408969
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,244 @@ object SpecifiedWindowF
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47408697
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -870,26 +878,37 @@ class Analyzer(
//
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47408553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -187,7 +184,7 @@ sealed abstract class A
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47407972
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,244 @@ object SpecifiedWindowF
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47407885
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -120,6 +121,19 @@ sealed trait FrameBoundar
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47407165
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -70,15 +70,32 @@ trait CheckAnalysis {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47406991
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,244 @@ object SpecifiedWindowFrame
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47406652
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -246,85 +260,244 @@ object SpecifiedWindowFrame
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47406503
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -120,6 +121,19 @@ sealed trait FrameBoundary {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47406421
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -70,15 +70,32 @@ trait CheckAnalysis {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47405512
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -187,7 +184,7 @@ sealed abstract class Aggre
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47312982
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -328,3 +281,222 @@ object FrameBoundaryExtracto
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47185637
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -870,26 +878,37 @@ class Analyzer(
// Now,
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47185283
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -70,15 +70,32 @@ trait CheckAnalysis {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-163325455
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-163325453
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-163325253
**[Test build #47428 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47428/consoleFull)**
for PR 9819 at commit
[`5fefcf0`](https://git
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47105986
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -870,26 +878,37 @@ class Analyzer(
//
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9819#issuecomment-163291397
**[Test build #47428 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47428/consoleFull)**
for PR 9819 at commit
[`5fefcf0`](https://gith
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47073901
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -328,3 +281,222 @@ object FrameBoundaryExtr
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47073846
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -328,3 +281,222 @@ object FrameBoundaryExtr
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47072914
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -592,11 +594,17 @@ class Analyzer(
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47071980
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -328,3 +281,222 @@ object FrameBoundaryExtr
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47037900
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -328,3 +281,222 @@ object FrameBoundaryExtracto
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9819#discussion_r47035952
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -328,3 +281,222 @@ object FrameBoundaryExtracto
1 - 100 of 167 matches
Mail list logo
