Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118763844
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7038
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118954773
Ok, I'm merging this into master. Thanks @thegiive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33873825
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala ---
@@ -107,4 +107,6 @@ private[spark] class WorkerInfo(
def
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33873807
--- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala ---
@@ -76,12 +76,13 @@ private[deploy] object JsonProtocol {
}
Github user thegiive commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118449368
HI @andrewor14
The test is passed. If there is any problem, please let me know. Thanks
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118438713
[Test build #36515 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36515/console)
for PR 7038 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118438727
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user thegiive commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33881284
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala ---
@@ -107,4 +107,6 @@ private[spark] class WorkerInfo(
def
Github user thegiive commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33881472
--- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala ---
@@ -76,12 +76,13 @@ private[deploy] object JsonProtocol {
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33882364
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala ---
@@ -107,4 +107,6 @@ private[spark] class WorkerInfo(
def
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118431806
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118431800
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user thegiive commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33881442
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala ---
@@ -107,4 +107,6 @@ private[spark] class WorkerInfo(
def
Github user thegiive commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33881264
--- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala ---
@@ -76,12 +76,13 @@ private[deploy] object JsonProtocol {
}
Github user thegiive commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33881396
--- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala ---
@@ -76,12 +76,13 @@ private[deploy] object JsonProtocol {
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118431965
[Test build #36515 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36515/consoleFull)
for PR 7038 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-117936713
ic - to me it is almost incorrect in the past, and we are fixing a bug here
...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-117922942
what's the non-compatible part?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-117922427
Hm I just saw @srowen's comment. Actually this change is not backward
compatible so I'm not sure if we can merge it. @rxin any thoughts?
---
If your project is set
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-117936180
I think just that the response will have different information now -- are
people relying on and properly expecting to get info for all workers in the
JSON? then removing
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118214540
[Test build #36464 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36464/consoleFull)
for PR 7038 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118214510
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user thegiive commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118214522
Hi all reviewer
I modified the code base on the comment.
Can you check if it is ok ?
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118214499
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118227376
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-118227357
[Test build #36464 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36464/console)
for PR 7038 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-116832820
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-116833438
[Test build #36030 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36030/consoleFull)
for PR 7038 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-116834206
[Test build #36030 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36030/console)
for PR 7038 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-116832022
@thegiive have you verified that these are the only sources of mismatch?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-116834403
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33508453
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala ---
@@ -107,4 +107,8 @@ private[spark] class WorkerInfo(
def
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-116831567
OK TO TEST
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-116831720
I think we should have the JSON protocol do whatever the normal UI does.
This change looks fine.
---
If your project is set up for it, you can reply to this email
Github user thegiive commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33364777
--- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala ---
@@ -77,11 +77,11 @@ private[deploy] object JsonProtocol {
def
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-115635388
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user thegiive commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33364667
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala ---
@@ -107,4 +107,8 @@ private[spark] class WorkerInfo(
def
Github user thegiive commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-115725659
HI Sean, thanks for your opinion.
My feeling is that WebUI and API is just different presentation format. But
the content should be the same. Different
Github user thegiive commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-115898969
Base on git blame, I think the JSON API creator is @rxin ( 9db1e503 )
Hi Reynold
#6317 has already change some master UI's data's definition (total
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7038#issuecomment-115647605
This is changing the semantics of the response though. I don't think you
can necessarily do this. It is not necessarily true that what is presented in
the web UI for
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33346345
--- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala ---
@@ -77,11 +77,11 @@ private[deploy] object JsonProtocol {
def
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7038#discussion_r33346369
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala ---
@@ -107,4 +107,8 @@ private[spark] class WorkerInfo(
def
GitHub user thegiive opened a pull request:
https://github.com/apache/spark/pull/7038
[SPARK-8656][WebUI] Fix the webUI and JSON API number is not synced
Spark standalone master web UI show Alive workers worker number, Alive
Workers total core, total used cores and Alive workers
44 matches
Mail list logo
