[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-16 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9216#discussion_r45013077 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala --- @@ -194,7 +194,9 @@ case class AttributeReference

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9216#discussion_r45011838 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala --- @@ -194,7 +194,9 @@ case class AttributeReferen

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9216#discussion_r45011411 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala --- @@ -194,7 +194,9 @@ case class AttributeReferenc

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9216 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-16 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-157206264 Thanks, I'm going to merge this to master and 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156722071 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156722073 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156722038 **[Test build #45932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45932/consoleFull)** for PR 9216 at commit [`5decf82`](https://git

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156711134 **[Test build #45932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45932/consoleFull)** for PR 9216 at commit [`5decf82`](https://gith

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156614300 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156614302 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156614280 **[Test build #45919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45919/consoleFull)** for PR 9216 at commit [`8e72b17`](https://git

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156611601 **[Test build #45919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45919/consoleFull)** for PR 9216 at commit [`8e72b17`](https://gith

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156605414 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156605415 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156605370 **[Test build #45901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45901/consoleFull)** for PR 9216 at commit [`4425dbc`](https://git

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-156580060 **[Test build #45901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45901/consoleFull)** for PR 9216 at commit [`4425dbc`](https://gith

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-11-03 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-153511090 @JoshRosen @cloud-fan I submitted a pull request for JIRA Spark-11275: https://github.com/apache/spark/pull/9419 Hopefully, after finishing the problem, this

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-22 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150486350 The JIRA is opened: https://issues.apache.org/jira/browse/SPARK-11275 I will continue the investigation on this JIRA issue. --- If your project is set up fo

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-22 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150475832 Hi, @cloud-fan Sure. Will do. I am trying to see if I can easily fix it. Anyway, I will open a JIRA tonight. Thanks, Xiao Li --- If you

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-22 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150467231 Hi @gatorsmile , thanks for working on it! Do you mind opening a new JIRA to describe the rollup and cube bug you discovered? I think we should open another PR to f

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-22 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150395202 My code change expose a new defect: Both rollup and cube are not working correctly no matter whether the build include my changes or not. Without my c

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150126161 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150126107 **[Test build #44134 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44134/consoleFull)** for PR 9216 at commit [`029b5ba`](https://git

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150126159 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150111709 **[Test build #44134 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44134/consoleFull)** for PR 9216 at commit [`029b5ba`](https://gith

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150111409 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150111429 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-21 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-15017 Actually, maybe we don't need one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-21 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-15028 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-21 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150111043 Can you add a regression test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-21 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/9216 [SPARK-8658] [SQL] AttributeReference's equals method compares all the members This fix is to change the equals method to check all of the specified fields for equality of AttributeReference. Y

[GitHub] spark pull request: [SPARK-8658] [SQL] AttributeReference's equals...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150105599 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr