[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-30 Thread saurfang
Github user saurfang commented on a diff in the pull request: https://github.com/apache/spark/pull/7082#discussion_r33608396 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -572,55 +572,55 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-30 Thread saurfang
Github user saurfang commented on a diff in the pull request: https://github.com/apache/spark/pull/7082#discussion_r33610564 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -572,55 +572,55 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-30 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/7082#discussion_r33614524 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -572,55 +572,55 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-30 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/7082#discussion_r33609917 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -572,55 +572,55 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116682495 Oh, I see. could you file another one as a separate issue? Opened a JIRA for this issue: https://issues.apache.org/jira/browse/SPARK-8705 --- If your project

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116657416 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116658293 [Test build #35985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35985/consoleFull) for PR 7082 at commit

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116657944 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116669695 LGTM. After test #35985 pass, I'll merge this into `master`. Thanks @zsxwing for your contribution! --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/7082#discussion_r33462776 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -572,55 +572,55 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/7082#discussion_r33462112 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -572,55 +572,55 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116656454 [Test build #979 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/979/console) for PR 7082 at commit

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116657924 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116659288 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116659244 [Test build #35980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35980/console) for PR 7082 at commit

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116621564 [Test build #979 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/979/consoleFull) for PR 7082 at commit

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116630589 Oh, I see. could you file another one as a separate issue? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/7082#discussion_r33457314 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -572,55 +572,55 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116612731 @sarutak I also find another issue in the console. Because `System.currentTimeMillis()` is not accurate for tasks that only need several milliseconds, sometimes

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116609513 [Test build #35980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35980/consoleFull) for PR 7082 at commit

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116737691 [Test build #35985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35985/console) for PR 7082 at commit

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116737751 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116608173 /cc @sarutak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/7082 [SPARK-8702][WebUI]Avoid massive concating strings in Javascript When there are massive tasks, such as `sc.parallelize(1 to 10, 1).count()`, the generated JS codes have a lot of string

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116608318 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8702][WebUI]Avoid massive concating str...

2015-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7082#issuecomment-116608379 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not