Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7927
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-137572073
LGTM merging into master, thanks everyone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-137372107
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-137372105
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-137372017
[Test build #41960 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41960/console)
for PR 7927 at commit
[`6c6d53d`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-137333723
[Test build #41960 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41960/consoleFull)
for PR 7927 at commit
[`6c6d53d`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-137333165
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-137333173
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-137332857
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-137046713
It seems that the failure not related.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136942619
[Test build #41907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41907/console)
for PR 7927 at commit
[`6c6d53d`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136942750
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136942752
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136920246
[Test build #41907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41907/consoleFull)
for PR 7927 at commit
[`6c6d53d`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136919732
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136919718
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136911264
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136911263
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136911190
[Test build #41899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41899/console)
for PR 7927 at commit
[`75db334`](https://github.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136887215
@jeanlyn can you rename the title of this patch and the issue to remove
references to "broadcast"? I believe this is applicable to all blocks in
general.
---
If you
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r38482388
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,25 @@ private[spark] class BlockManager(
private def d
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r38482018
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,25 @@ private[spark] class BlockManager(
private def d
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136884719
[Test build #41899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41899/consoleFull)
for PR 7927 at commit
[`75db334`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136883680
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136883648
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r38481057
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,25 @@ private[spark] class BlockManager(
private def d
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-136883210
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user GraceH commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36596179
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,21 @@ private[spark] class BlockManager(
private def doGet
Github user jeanlyn commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36587468
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,24 @@ private[spark] class BlockManager(
private def doGe
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36557012
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,24 @@ private[spark] class BlockManager(
private def doGet
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36556866
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations =
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36556522
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockFetchException.scala ---
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36556494
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,21 @@ private[spark] class BlockManager(
private def doGet
Github user jeanlyn commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-128582275
Thanks everyone for the review! I updated the code, and now `doGetRemote`
will accept exception when we still have location to fetch the block avoiding
the work flow bei
Github user GraceH commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36372781
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,21 @@ private[spark] class BlockManager(
private def doGet
Github user jeanlyn commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36302564
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +448,34 @@ class BlockManagerSuite extends SparkFunSuite with
Ma
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-127991678
thanks for updating @jeanlyn . Sorry that I didn't fully understand the
issue earlier and for potentially changing the desired outcome on you.
---
If your project is se
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36298102
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +448,34 @@ class BlockManagerSuite extends SparkFunSuite with
Mat
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36297953
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +448,34 @@ class BlockManagerSuite extends SparkFunSuite with
Mat
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36297624
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,21 @@ private[spark] class BlockManager(
private def doGet
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36297450
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,21 @@ private[spark] class BlockManager(
private def doGet
Github user jeanlyn commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36294518
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +448,37 @@ class BlockManagerSuite extends SparkFunSuite with
Ma
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36293219
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -590,10 +590,21 @@ private[spark] class BlockManager(
private def do
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36292648
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +448,37 @@ class BlockManagerSuite extends SparkFunSuite with
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36292639
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +448,37 @@ class BlockManagerSuite extends SparkFunSuite with
Github user GraceH commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36271550
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations =
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36235472
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +443,21 @@ class BlockManagerSuite extends SparkFunSuite with
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36235337
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36235201
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +443,21 @@ class BlockManagerSuite extends SparkFunSuite with
Github user jeanlyn commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36217402
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations =
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36204820
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +443,21 @@ class BlockManagerSuite extends SparkFunSuite with
Mat
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36202856
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations =
Github user jeanlyn commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36182323
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +443,21 @@ class BlockManagerSuite extends SparkFunSuite with
Ma
Github user jeanlyn commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36182313
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations =
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36180800
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations =
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36180526
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36180197
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36179774
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +443,21 @@ class BlockManagerSuite extends SparkFunSuite with
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36179785
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -443,6 +443,21 @@ class BlockManagerSuite extends SparkFunSuite with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7927#discussion_r36172665
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -592,8 +592,14 @@ private[spark] class BlockManager(
val locations =
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-127541931
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7927#issuecomment-127541700
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user jeanlyn opened a pull request:
https://github.com/apache/spark/pull/7927
[SPARK-9591][CORE]Job may fail for exception during getting broadcast
variable
[SPARK-9591](https://issues.apache.org/jira/browse/SPARK-9591)
When we getting the broadcast variable, we can fet
63 matches
Mail list logo