[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-12-15 Thread adamjk
Github user adamjk commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-164703283 Is this being backported to 1.5.x? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8026 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-22 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-150337486 LGTM, so I'm going to merge this into master. Should this be backported to 1.5.x or any earlier releases? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-150091423 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-150091422 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-150091343 **[Test build #44113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44113/consoleFull)** for PR 8026 at commit [`3383473`](https://git

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-150068875 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-150068962 **[Test build #44113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44113/consoleFull)** for PR 8026 at commit [`3383473`](https://gith

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-150068858 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-150068746 Yes, true, actually SPARK-7749 provides an example of Hive metastore backend empty partition table, then we will not detect any partition column values.

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-150021131 @chenghao-intel, it looks like this most recent test failure is legitimate: ``` assertion failed: Actual partitioning column names did not match user-speci

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149959480 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149959477 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149959310 **[Test build #44066 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44066/consoleFull)** for PR 8026 at commit [`bdee89e`](https://git

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149922732 **[Test build #44066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44066/consoleFull)** for PR 8026 at commit [`bdee89e`](https://gith

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149919423 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149919454 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-21 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149911447 Thank you @JoshRosen so much for the detail review, but seems bug exists, I'd like to solve it myself soon. --- If your project is set up for it, you can reply t

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149785524 @chenghao-intel, thanks a bunch for updating this; the current version of this patch is a lot easier to understand and I'm happy with how clean the code turned out. I

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42584080 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala --- @@ -510,21 +510,39 @@ abstract class HadoopFsRelationTest e

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42584058 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -544,11 +544,35 @@ abstract class HadoopFsRelation private[sql](mayb

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42584044 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -544,11 +544,35 @@ abstract class HadoopFsRelation private[sql](mayb

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42584024 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -544,11 +544,35 @@ abstract class HadoopFsRelation private[sql](mayb

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42583983 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -544,11 +544,35 @@ abstract class HadoopFsRelation private[sql](mayb

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42583969 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -544,11 +544,35 @@ abstract class HadoopFsRelation private[sql](mayb

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42583944 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -544,11 +544,35 @@ abstract class HadoopFsRelation private[sql](mayb

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42583857 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -544,11 +544,35 @@ abstract class HadoopFsRelation private[sql](mayb

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149783377 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149783376 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149783351 **[Test build #44040 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44040/consoleFull)** for PR 8026 at commit [`9f08f76`](https://git

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42583415 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -544,11 +544,35 @@ abstract class HadoopFsRelation private[sql](mayb

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42583431 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -544,11 +544,35 @@ abstract class HadoopFsRelation private[sql](mayb

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149781986 @JoshRosen I've updated the code, should be more straightforward and clean --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149781507 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149781506 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149781486 **[Test build #44038 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44038/consoleFull)** for PR 8026 at commit [`2cc93da`](https://git

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149781430 **[Test build #44040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44040/consoleFull)** for PR 8026 at commit [`9f08f76`](https://gith

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149779487 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149779455 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149777383 **[Test build #44038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44038/consoleFull)** for PR 8026 at commit [`2cc93da`](https://gith

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149776551 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149776594 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42575993 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -236,15 +241,22 @@ private[sql] object Par

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42575628 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -134,17 +137,38 @@ private[sql] object Par

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42533868 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -134,17 +137,38 @@ private[sql] object Partitio

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149627957 **[Test build #43984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43984/consoleFull)** for PR 8026 at commit [`7f2da8c`](https://git

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149628397 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149628393 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42509891 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -236,15 +241,22 @@ private[sql] object Partitio

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42509765 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala --- @@ -101,11 +118,13 @@ cl

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149598558 @JoshRosen I've updated the unit test also by adding an `Append` operation, without this PR, it will throws exception as I described in the jira (https://issues.a

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42506907 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -236,15 +241,22 @@ private[sql] object Par

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149591384 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149591577 **[Test build #43984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43984/consoleFull)** for PR 8026 at commit [`7f2da8c`](https://gith

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149591364 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42451442 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala --- @@ -458,6 +458,8 @@ abstract class HadoopFsRelationTes

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42451397 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala --- @@ -447,7 +447,7 @@ abstract class HadoopFsRelationTes

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42451143 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -236,15 +241,22 @@ private[sql] object Par

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149413572 Thank you @JoshRosen , I will pick up this PR as some details I almost forgot. But definitely, the ignored test cases will fail without this PR previously, not su

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149406766 I just tried testing a build where I _only_ re-enabled the ignored test and changed nothing else. In this case, the test still passed. This makes me wonder whether the

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42447350 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala --- @@ -101,11 +118,13 @@ class P

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42447317 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala --- @@ -458,6 +458,8 @@ abstract class HadoopFsRelationTest ext

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42447228 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -236,15 +241,22 @@ private[sql] object Partitio

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42446094 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala --- @@ -447,7 +447,7 @@ abstract class HadoopFsRelationTest ext

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-149390928 @chenghao-intel, just to clarify: I noticed that your final approach involved pushing an expected data type down into the method named `inferPartitionColumValue`. I'm

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-19 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r42445776 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -236,15 +241,22 @@ private[sql] object Partitio

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-10-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/8026#discussion_r41919664 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala --- @@ -447,7 +447,7 @@ abstract class HadoopFsRelationTest extend

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132480407 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132480410 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132480287 [Test build #41214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41214/console) for PR 8026 at commit [`cda059f`](https://github.

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132455893 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132455892 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132455872 [Test build #41202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41202/console) for PR 8026 at commit [`f68d827`](https://github.

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132451174 [Test build #41214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41214/consoleFull) for PR 8026 at commit [`cda059f`](https://gith

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132450499 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132450511 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132450163 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132447554 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132447550 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132447476 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132447507 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132446425 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132446390 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132446424 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132445340 [Test build #41211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41211/consoleFull) for PR 8026 at commit [`cda059f`](https://gith

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132445375 [Test build #41211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41211/console) for PR 8026 at commit [`cda059f`](https://github.

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132445384 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132445382 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-13249 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-13240 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132444093 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132444085 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132431832 [Test build #41202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41202/consoleFull) for PR 8026 at commit [`f68d827`](https://gith

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132430775 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-132430765 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-07 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-128643963 A summary of my offline discussion with @chenghao-intel: The real problem here is that the partition column types of the newly refreshed partition spec don't m

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-128619293 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-128616385 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-128616376 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9735][SQL]Respect the user specified sc...

2015-08-06 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8026#issuecomment-128615201 cc @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

  1   2   >