[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-27 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-135574246 merging with master and branch-1.5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-27 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-135574233 I'll go ahead and merge this and ask @feynmanliang to make any needed updates when he sends a PR for the linear regression summary docs. Thanks! --- If your project

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37896794 --- Diff: docs/ml-linear-methods.md --- @@ -23,20 +23,41 @@ displayTitle: a href=ml-guide.htmlML/a - Linear Methods \]` -In MLlib, we

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37896812 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37896801 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37896809 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37896807 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-25 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-134685351 Done with review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-24 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-134449756 LGTM CC @jkbradley this is blocking SPARK-9905 so do you mind reviewing when you have a chance? Thanks! --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132125000 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132124847 [Test build #41096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41096/console) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132124998 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132083744 @feynmanliang I have moved the guide to `ml-linear-models`. Can you give another pass? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132083259 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132084922 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132084903 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132087124 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132086638 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132086610 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132086612 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132088562 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132088488 [Test build #41094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41094/console) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132083150 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132087134 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132088707 [Test build #41096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41096/consoleFull) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132088561 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132085620 [Test build #41094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41094/consoleFull) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132309366 Cool LGTM, @jkbradley for final pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37336156 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132315680 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37337556 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132315683 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132323049 @feynmanliang Actually I'm not very convinced that coupling these with existing code is the way to go. We could have a `docs/ml-summary.md` in the future with

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37331604 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. + +Once

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37333263 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. + +Once

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132315466 [Test build #41151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41151/console) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132311220 [Test build #41151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41151/consoleFull) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37335210 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37335316 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37336590 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132306453 @MechCoder I sent you a PR, please merge if you like the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37336485 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights))

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132308590 I have merged your changes. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132308625 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132308575 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37335793 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37336212 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights))

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132343523 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37345734 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights))

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37345587 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights))

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132348205 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132348201 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37347155 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37347701 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights))

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132344168 [Test build #41162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41162/consoleFull) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132333581 Having a `ml-summary.md` would lead to quite a bit of repeated documentation; we would have to supply model training example code in both the model's description

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132341432 You are right. But I thought that the example code such as extracting the training loss, and common metrics would be repeated across some classification and

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132343547 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37349237 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights))

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132348051 [Test build #41162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41162/console) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132350267 Okay. But he had to told something else in that PR discussion :p. I do agree that doing model.binarySUmmary is much nearer than model.asInstanceOf[]… On

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-18 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37347889 --- Diff: docs/ml-linear-methods.md --- @@ -118,12 +133,114 @@ lrModel = lr.fit(training) print(Weights: + str(lrModel.weights)) print(Intercept:

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37255384 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37255388 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37256585 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132009598 I think this should be part of the linear methods section, not part of the main ML guide. Once we have summary support in more model types, then we can mention it in

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37255300 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37255796 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37256629 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37256686 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132015185 :+1: to @jkbradley 's suggestion; my apologies for not thinking of that and the misleading JIRA task description. I've updated the JIRA to reflect this. --- If

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37254999 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132016183 @MechCoder I am working on LinearRegressionSummary docs (SPARK-9905) and I think we should communicate about where these docs should go. What do you think about

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37255149 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. --- End

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37255082 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37255190 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132019803 @feynmanliang That organization sounds good, if the summary examples can make use of previous basic examples (and avoid copying code). Another option would be to

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37255160 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. --- End

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37255176 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. --- End

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-132070173 @feynmanliang All right, I shall reorganize the code right now. Could you wait for the LinearRegressionSummary till this is merged? It would make things simpler.

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-17 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37265276 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,153 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. + +Once

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131523642 [Test build #40988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40988/consoleFull) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131523608 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131523605 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131525240 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131525225 [Test build #40988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40988/console) for PR 8197 at commit

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131525241 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131523407 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131523403 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131524525 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131524527 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37140446 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,146 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-15 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37141832 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,141 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. + +Once

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-15 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8197#discussion_r37140382 --- Diff: docs/ml-guide.md --- @@ -801,6 +801,141 @@ jsc.stop(); /div +## Examples: Summaries for LogisticRegression. +

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131491134 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131491137 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-15 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131491133 Lgtm pending tests @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131491136 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9906] [ML] User guide for LogisticRegre...

2015-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8197#issuecomment-131491132 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

  1   2   >