Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147909733
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147929731
Thanks @mfliu - LGTM. Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9029
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9029#discussion_r41898036
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1414,9 +1414,10 @@ setMethod("where",
#' @param x A Spark DataFrame
#' @param y A Spark DataFrame
#'
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147829269
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147832715
[Test build #43666 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43666/consoleFull)
for PR 9029 at commit
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147844123
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147838614
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147843796
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147843748
[Test build #43668 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43668/console)
for PR 9029 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147843798
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147844952
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147828913
[Test build #43664 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43664/consoleFull)
for PR 9029 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147830691
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147830747
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147833867
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147833871
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147833846
[Test build #43666 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43666/console)
for PR 9029 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147838635
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147839651
[Test build #43668 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43668/consoleFull)
for PR 9029 at commit
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147839679
@mfliu Just FYI, you can check the lint-r tests locally by running the
script `dev/lint-r`
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147844883
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147827752
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147827696
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147829263
[Test build #43664 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43664/console)
for PR 9029 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147829272
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147850255
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147850221
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147845868
[Test build #43671 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43671/consoleFull)
for PR 9029 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147850942
[Test build #43673 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43673/consoleFull)
for PR 9029 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147852003
[Test build #43671 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43671/console)
for PR 9029 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147852147
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147852150
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147855830
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147855832
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147855661
[Test build #43673 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43673/console)
for PR 9029 at commit
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-147859792
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/9029#discussion_r41691353
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1414,9 +1414,10 @@ setMethod("where",
#' @param x A Spark DataFrame
#' @param y A Spark DataFrame
#'
Github user mfliu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9029#discussion_r41649096
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1414,9 +1414,10 @@ setMethod("where",
#' @param x A Spark DataFrame
#' @param y A Spark DataFrame
#' @param
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9029#discussion_r41648156
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1414,9 +1414,10 @@ setMethod("where",
#' @param x A Spark DataFrame
#' @param y A Spark DataFrame
#'
Github user mfliu commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146914689
That change was made based on the comment on the JIRA report:
https://issues.apache.org/jira/browse/SPARK-10981
In the PR, please:
1. Support all join
Github user mfliu commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146882602
Sorry, had a typo in one of my unit tests. It now passes the run-tests.sh
on my machine. Can you test again?
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146884080
[Test build #43469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43469/console)
for PR 9029 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146884084
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146884082
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146881285
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146881195
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146883721
[Test build #43469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43469/consoleFull)
for PR 9029 at commit
Github user mfliu commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146872159
@felixcheung Yes, you are correct. The arrange function was different. I
pulled again and changed those files and it is working on my machine. Can you
test again?
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146872375
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146872420
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146873838
[Test build #43468 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43468/consoleFull)
for PR 9029 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146874145
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146874146
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146874133
[Test build #43468 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43468/console)
for PR 9029 at commit
Github user mfliu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9029#discussion_r41663399
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1414,9 +1414,10 @@ setMethod("where",
#' @param x A Spark DataFrame
#' @param y A Spark DataFrame
#' @param
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9029#discussion_r41662805
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1414,9 +1414,10 @@ setMethod("where",
#' @param x A Spark DataFrame
#' @param y A Spark DataFrame
#'
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146895645
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146895610
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146897203
[Test build #43473 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43473/consoleFull)
for PR 9029 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146901456
[Test build #43473 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43473/console)
for PR 9029 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146901604
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146901607
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146655649
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146655645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mfliu commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146672272
The errors in the log file don't seem to be related to the changes I made?
They are primarily in PythonRDD.scala:
java.net.SocketException: Socket is closed
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146681852
@mfliu I think thats just a flaky test, but irrespective of that your
changes should be against the current `master` branch. Right now it looks like
there are a lot
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9029#discussion_r41592873
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1314,50 +1273,21 @@ setClassUnion("characterOrColumn", c("character",
"Column"))
#' path <-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9029#discussion_r41592919
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1854,30 +1784,36 @@ setMethod("fillna",
sdf <- if (length(cols) == 0) {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146651225
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9029#issuecomment-146651254
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
71 matches
Mail list logo
