[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155291960 Alright I'm merging this to catch 1.6. @sun-rui if we have more points to discuss, we can continue on the mailing list or JIRA. --- If your project is set up for it, y

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155280440 Yeah thats a good point. I mostly prefer (1) because it makes our code base only contain S4 functions. However we do end up with a risk of bugs like this one. I do like

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155274214 LGTM. I just want to discuss a BKM here for all cases of such kind. That is we want to add in SparkR a function which also an existing S3 geneirc function defi

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155263685 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155263679 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155263501 **[Test build #45465 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45465/consoleFull)** for PR 9582 at commit [`6b40b0f`](https://git

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155260289 **[Test build #45465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45465/consoleFull)** for PR 9582 at commit [`6b40b0f`](https://gith

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155258426 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155258445 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread shivaram
GitHub user shivaram opened a pull request: https://github.com/apache/spark/pull/9582 [SPARKR] [SPARK-11587] Fix the summary generic to match base R The signature is summary(object, ...) as defined in https://stat.ethz.ch/R-manual/R-devel/library/base/html/summary.html You can m

[GitHub] spark pull request: [SPARKR] [SPARK-11587] Fix the summary generic...

2015-11-09 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/9582#issuecomment-155258328 cc @mengxr @yanboliang @sun-rui --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no