Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2764
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2764#issuecomment-67381357
Sorry for the delay here. I think it would be good to clean up how we do
pattern matching and this looks like a good start. Here's what I propose:
- close this iss
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2764#issuecomment-61400524
@marmbrus This should be ready to go since #2983 has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2764#issuecomment-61361922
Rebased to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2764#discussion_r19135372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -319,10 +315,8 @@ case object ByteType extends IntegralTyp
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2764#discussion_r19118592
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -319,10 +315,8 @@ case object ByteType extends IntegralType
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2764#discussion_r19118466
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -107,20 +107,20 @@ trait HiveTypeCoercion {
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2764#issuecomment-58951446
This does look like a better style that what we were doing before. We
should coordinate with the changes @mateiz is making for decimal type.
---
If your project is set
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2764#discussion_r18740906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -107,20 +107,20 @@ trait HiveTypeCoercion {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2764#issuecomment-58743014
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21640/consoleFull)
for PR 2764 at commit
[`f391be5`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2764#issuecomment-58743015
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2764#issuecomment-58742085
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21640/consoleFull)
for PR 2764 at commit
[`f391be5`](https://github.com/ap
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2764#issuecomment-58742036
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/2764
[SQL] Refactors data type pattern matching
Refactors/adds extractors for `DataType` and `Binary*` types to ease and
simplify data type related (nested) pattern matching.
You can merge this pull r
14 matches
Mail list logo
