Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-125667585
sorry forgot to get back to this. Sure, I'll close. I think its not ideal
that our leak-detector is just waiting for users to complain, but I also have
no idea how
Github user squito closed the pull request at:
https://github.com/apache/spark/pull/5463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-122458582
Any thoughts this? If not, mind closing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-121429859
Yeah, unless this is a serious issue that is causing problems, I am
reluctant to touch so much code to change this. So for now mind closing this
PR? We can always open it
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-120440543
Hi @JoshRosen @tdas --- sorry somehow I missed Josh's earlier comment. I
don't think https://github.com/apache/spark/pull/6423 fully solved this issue.
We are still
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-120150258
@all, Is this PR still relevant. If not mind closing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-111743133
@squito, will #6423 end up fixing this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-94051965
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-94052759
[Test build #30495 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30495/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-94077313
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-94077306
[Test build #30495 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30495/consoleFull)
for PR 5463 at commit
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93803024
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93803696
[Test build #30430 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30430/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93827549
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93827537
**[Test build #30430 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30430/consoleFull)**
for PR 5463 at commit
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93854101
anybody have any idea what is going on here? the tests all run fine on my
laptop. Its slow, but not so much worse than before. The logs seem to
indicate everything is
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5463#discussion_r28434599
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -755,104 +769,115 @@ private[spark] class BlockManager(
case _ =
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93461723
[Test build #30350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30350/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93465485
[Test build #30351 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30351/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93519270
[Test build #30350 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30350/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93519347
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93522789
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93522744
**[Test build #30351 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30351/consoleFull)**
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93535270
[Test build #30368 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30368/consoleFull)
for PR 5463 at commit
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93533480
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93598539
**[Test build #30377 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30377/consoleFull)**
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93598549
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93576521
[Test build #30377 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30377/consoleFull)
for PR 5463 at commit
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93608332
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93608902
[Test build #30388 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30388/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93624294
**[Test build #30388 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30388/consoleFull)**
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93624304
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93573347
[Test build #30368 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30368/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-93573359
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92454492
[Test build #30177 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30177/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92445769
[Test build #30169 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30169/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92445803
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92452706
[Test build #30175 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30175/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92454126
[Test build #30177 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30177/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92454499
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92457831
[Test build #30180 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30180/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92490886
[Test build #30175 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30175/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92490912
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5463#discussion_r28278804
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -755,104 +769,115 @@ private[spark] class BlockManager(
case _ =
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5463#discussion_r28278835
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -755,104 +769,115 @@ private[spark] class BlockManager(
case _ =
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5463#discussion_r28283431
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -755,104 +769,115 @@ private[spark] class BlockManager(
case _ =
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5463#discussion_r28283453
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockStore.scala ---
@@ -22,13 +22,18 @@ import java.nio.ByteBuffer
import
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92512403
I talked to @squito offline and it doesn't seem like there's a less
intrusive solution to this issue, so this looks OK to me. But I'm not that
familiar with these code
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92491757
[Test build #30180 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30180/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92491779
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92408211
[Test build #30169 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30169/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92179758
[Test build #30130 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30130/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92179785
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92186450
[Test build #30134 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30134/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92186454
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92183786
[Test build #30136 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30136/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92205170
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92169356
[Test build #30130 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30130/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92173500
[Test build #30134 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30134/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-92205153
[Test build #30136 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30136/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-91736017
[Test build #30063 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30063/consoleFull)
for PR 5463 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-91736215
[Test build #30063 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30063/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-91736218
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-91737691
[Test build #30064 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30064/consoleFull)
for PR 5463 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-91738272
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5463#issuecomment-91738270
[Test build #30064 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30064/consoleFull)
for PR 5463 at commit
66 matches
Mail list logo
