[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215226799 I fixed the title while merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215225764 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215225766 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215225477 **[Test build #57161 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57161/consoleFull)** for PR 12734 at commit [`442265e`](https://g

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215198462 **[Test build #57161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57161/consoleFull)** for PR 12734 at commit [`442265e`](https://gi

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215198428 Changes look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215198362 @liancheng The last commit adds a new test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12734#discussion_r61318397 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -264,9 +265,16 @@ class SparkSqlAstBuilder(conf: SQLConf) extends

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215191068 oh, I cannot change it. @liancheng will change the title after he gets up :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread jodersky
Github user jodersky commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215189992 Could you change the title to `[SPARK-14954] (current title)`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215188645 Yea. https://issues.apache.org/jira/browse/SPARK-14954 is the jira. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread jodersky
Github user jodersky commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215186982 Does this pr fix a ticket? In that case it would be useful to change the title to include the [SPARK-] prefix so that the JIRA status gets updated --- If your projec

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12734#discussion_r61305260 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -264,9 +265,16 @@ class SparkSqlAstBuilder(conf: SQLConf) extends

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12734#discussion_r61303166 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -264,9 +265,16 @@ class SparkSqlAstBuilder(conf: SQLConf) extends

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12734#discussion_r61302579 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -264,9 +265,16 @@ class SparkSqlAstBuilder(conf: SQLConf) extends

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215164079 For `DataFrameWriter`, can we do `sortBy` without using `bucketBy`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215131297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215131294 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215130925 **[Test build #57129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57129/consoleFull)** for PR 12734 at commit [`a193faf`](https://g

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215107260 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215107256 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215107049 **[Test build #57127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57127/consoleFull)** for PR 12734 at commit [`af973d6`](https://g

[GitHub] spark pull request: Add PARTITION BY and BUCKET BY clause for data...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12734#issuecomment-215099565 **[Test build #57129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57129/consoleFull)** for PR 12734 at commit [`a193faf`](https://gi