Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-52275155
Hey this looks good. Merging it now into mater. Sorry about the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user nkronenfeld commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50836302
OK, @pwendel, I think it's set now. Let me know if there are merge
problems, I can resubmit on a clean branch if necessary.
---
If your project is set up for it, y
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50832292
QA results for PR 1535:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50828214
QA tests have started for PR 1535. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17612/consoleFull
---
If
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50660639
yeah to keep it simple let's just always have it show memory. I'd rather
not add a new public API for this `showMemory` thing at the moment.
---
If your project is set
Github user nkronenfeld commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50621396
Thanks, @pwendel. I can revert it back if you want - is that preferable to
the way it is now, with the option to include the memory info or not?
I'll start w
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50579659
Hey @nkronenfeld - I traced through the exact function call more closely
and I actually think it's fine. The issue I pointed out in the JIRA is
orthogonal. So I'm fine t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50507822
QA results for PR 1535:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50501244
QA tests have started for PR 1535. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17363/consoleFull
---
If
Github user nkronenfeld commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50487526
If I'm reading that correctly, that test failure is from an MLLib change
that's nothing to do with what I've done? Perhaps I'll just try it again,
maybe it's a bad s
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50419441
QA results for PR 1535:- This patch FAILED unit tests.For more
information see test
ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17310/consol
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50410853
QA tests have started for PR 1535. This patch DID NOT merge cleanly!
View progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17310/consoleFull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50407668
QA results for PR 1535:- This patch FAILED unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50401197
QA tests have started for PR 1535. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17304/consoleFull
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50388630
QA results for PR 1535:- This patch FAILED unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50388544
QA tests have started for PR 1535. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17302/consoleFull
---
If
Github user nkronenfeld commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-50388139
I just parameterized the memory so one can display it or not as desired
(with not displaying it the default) - is that sufficient?
I forgot to put in the note
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1535#discussion_r15324282
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1269,6 +1269,19 @@ abstract class RDD[T: ClassTag](
/** A description of thi
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1535#discussion_r15324267
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1269,6 +1269,19 @@ abstract class RDD[T: ClassTag](
/** A description of thi
Github user GregOwen commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49926584
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user nkronenfeld commented on a diff in the pull request:
https://github.com/apache/spark/pull/1535#discussion_r15308845
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1269,6 +1269,19 @@ abstract class RDD[T: ClassTag](
/** A description of
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/1535#discussion_r15307173
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1269,6 +1269,19 @@ abstract class RDD[T: ClassTag](
/** A description of thi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49890189
QA results for PR 1535:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49875467
QA tests have started for PR 1535. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17035/consoleFull
---
If
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49874874
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user nkronenfeld commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49870919
I'm not sure what to do about this test failure; all I've changed is
toDebugString, and this is in a spark streaming test which never calls that, so
I'm pretty sure i
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49831636
QA results for PR 1535:- This patch FAILED unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49827241
QA tests have started for PR 1535. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17008/consoleFull
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49825506
QA results for PR 1535:- This patch FAILED unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49825462
QA tests have started for PR 1535. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17005/consoleFull
---
If
Github user nkronenfeld commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49825329
thanks mark, I had no idea that existed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/1535#discussion_r15259034
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1294,7 +1307,11 @@ abstract class RDD[T: ClassTag](
val partitionStr = "("
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/1535#discussion_r15258957
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1294,7 +1307,11 @@ abstract class RDD[T: ClassTag](
val partitionStr = "("
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49799385
@gowen mind taking a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49798677
QA results for PR 1535:- This patch FAILED unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49798572
QA tests have started for PR 1535. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16987/consoleFull
---
If
Github user nkronenfeld commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49797427
Sorry, forgot to move one small formatting issue over from the old branch,
I'll check that in as soon as I test it.
---
If your project is set up for it, you can rep
Github user nkronenfeld commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49783708
Done, and I also left a comment on Greg Owen's PR from yesterday asking him
for formatting comments
---
If your project is set up for it, you can reply to this email
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1535#issuecomment-49782942
Hey, do you mind putting an example of what the output looks like in the PR
description?
---
If your project is set up for it, you can reply to this email and have your
GitHub user nkronenfeld opened a pull request:
https://github.com/apache/spark/pull/1535
Add caching information to rdd.toDebugString
I find it useful to see where in an RDD's DAG data is cached, so I figured
others might too.
I've added both the caching level, and the actu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1532#issuecomment-49749243
QA results for PR 1532:- This patch FAILED unit tests.For more
information see test
ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16966/consol
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1532#issuecomment-49749136
QA tests have started for PR 1532. This patch DID NOT merge cleanly!
View progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16966/consoleFull
Github user nkronenfeld closed the pull request at:
https://github.com/apache/spark/pull/1532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user nkronenfeld opened a pull request:
https://github.com/apache/spark/pull/1532
Add caching information to RDD.toDebugString
I find it useful to see where in an RDD's DAG data is cached, so I figured
others might too.
I've added both the caching level, and the actu
45 matches
Mail list logo
