Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-42126473
Yes, but those are transitive dependencies. `core` happens to bring in both
lang and lang3, and this was using the old lang dependency even. It would be
correct-er to
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-42132244
If we are depending on something and bundling it, we might as well use it
instead of duplicating code and having to maintain the changes : assuming
it is intutive
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-42137398
That makes sense. Since Tachyon now brings in `lang3`, it is no extra
burden to use it. It would rationalize the use in `ReplSuite`. Anyone second a
PR a to bring _back_
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-42144008
Yes, lang3 - not lang : some of the methods (for example, the escape method
used in repl) is actually broken in lang, but works in lang3.
On Sun, May 4,
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-42150290
I'm ambivalent between inlining this and fixing up the dependency. In
general we should probably rely on other utilities where possible, but if the
JVM ever changes the
Agree, this has not changed since java 1.1 or so. The niggling remaining
issue is that a test does use it too so technically needs the dependency
tweak anyway. And tachyon already brings it in.
That use can't be inlined but pretty certain is just a string replace. I
don't know if tachyon's use is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-42116492
The problem was that the project was not depending on commons lang already.
The code is the same as is contained in commons lang. The property being
referenced is a
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-42120375
Maven dependency still shows org.apache.commons:commons-lang3:jar - am I
missing something here ?
Btw, we do depend on it for repl tests too ...
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-41526096
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14526/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-41526093
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-41522557
Jenkins, test this please.
Looks good to me, pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-41524258
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-41524423
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-41524433
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user witgo opened a pull request:
https://github.com/apache/spark/pull/569
Fix SPARK-1629: Spark should inline use of commons-lang `SystemUtils.IS_...
...OS_WINDOWS`
You can merge this pull request into a Git repository by running:
$ git pull
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/569#issuecomment-41486930
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/569#discussion_r12027354
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1056,4 +1055,11 @@ private[spark] object Utils extends Logging {
def
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/569#discussion_r12027664
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1058,6 +1057,12 @@ private[spark] object Utils extends Logging {
}
19 matches
Mail list logo
