Github user steveloughran closed the pull request at:
https://github.com/apache/spark/pull/8766
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-19852
Yes let's just do that. There's no point in introducing another system
clock and call it something else. Let's just fix the existing one.
---
If your project is set
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-149554897
If people are happy with that, I'll do that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-148823517
Actually, why introduce another clock here, why not just change
`SystemClock` to use `System.nanoTime`?
---
If your project is set up for it, you can reply to this e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141206557
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141206556
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141206479
[Test build #42610 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42610/console)
for PR 8766 at commit
[`10ea2f3`](https://github.
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141164621
This is what my `clock_gettime(3)` man page says:
Historical note for SMP systems
Before Linux added kernel support for CLOCK_PROCESS_CPUTIME_ID and
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141160203
Marcelo, I'm not sure I trust nanoTime any more: I did some reading on the
topic and don't think code can be confident it works (i.e. is monotonic and
consistent)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141154791
[Test build #42610 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42610/consoleFull)
for PR 8766 at commit
[`10ea2f3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141152773
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141152689
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141150828
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-141033106
test failure is `org.apache.spark.streaming.CheckpointSuite.recovery with
invertible reduceByKeyAndWindow operation`; appears unrelated.
---
If your project is se
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39653380
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,12 +21,22 @@ package org.apache.spark.util
* An interface to represent clocks,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140769900
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140769896
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140769716
[Test build #42535 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42535/console)
for PR 8766 at commit
[`10ea2f3`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140728982
[Test build #42535 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42535/consoleFull)
for PR 8766 at commit
[`10ea2f3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140727709
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140727671
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39622785
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -26,7 +26,7 @@ import com.codahale.metrics.{Gauge, MetricRegistry}
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39622552
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -65,3 +75,18 @@ private[spark] class SystemClock extends Clock {
-1
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39622560
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -44,7 +54,7 @@ private[spark] class SystemClock extends Clock {
*/
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39622461
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -65,3 +75,18 @@ private[spark] class SystemClock extends Clock {
-1
-
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39622243
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,12 +21,22 @@ package org.apache.spark.util
* An interface to represent c
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140466423
Mostly style nits, but there seems to be a real bug in there. Otherwise,
looks good.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39536895
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -65,3 +75,18 @@ private[spark] class SystemClock extends Clock {
-1
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39536841
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -65,3 +75,18 @@ private[spark] class SystemClock extends Clock {
-1
--- End
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39536749
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -44,7 +54,7 @@ private[spark] class SystemClock extends Clock {
*/
def wai
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39536647
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -65,3 +75,18 @@ private[spark] class SystemClock extends Clock {
-1
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39536569
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,12 +21,22 @@ package org.apache.spark.util
* An interface to represent clocks,
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8766#discussion_r39536508
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -26,7 +26,7 @@ import com.codahale.metrics.{Gauge, MetricRegistry}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140397178
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140397182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140396872
[Test build #42485 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42485/console)
for PR 8766 at commit
[`a71af05`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140353867
[Test build #42485 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42485/consoleFull)
for PR 8766 at commit
[`a71af05`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140353351
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8766#issuecomment-140353281
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user steveloughran opened a pull request:
https://github.com/apache/spark/pull/8766
SPARK-10614 SystemClock uses non-monotonic time in its wait logic. Thâ¦
This patch adds a new subclass, `MonotonicClock`, and switches
`ExecutorAllocationManager` to using it (it used to use
40 matches
Mail list logo
