Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-73291550
Ok I'm merging this into master and 1.3 thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-73290287
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-73290279
[Test build #26921 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26921/consoleFull)
for PR 4141 at commit
[`a98bd20`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-73278693
[Test build #26921 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26921/consoleFull)
for PR 4141 at commit
[`a98bd20`](https://githu
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-73278012
Thanks for the review @andrewor14. Updated patch addresses your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4141#discussion_r24241097
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -124,10 +123,12 @@ private[yarn] class YarnAllocator(
amCli
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-73154620
Never mind I just found #4168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-73154458
@sryza this looks correct to me. My comments are mostly minor. Quick
question, do we have to do any additional thing for this to work with dynamic
allocation too or do
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4141#discussion_r24211162
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -192,15 +186,32 @@ private[yarn] class YarnAllocator(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4141#discussion_r24211037
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -192,15 +186,32 @@ private[yarn] class YarnAllocator(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4141#discussion_r24210976
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -124,10 +123,12 @@ private[yarn] class YarnAllocator(
amClie
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4141#discussion_r24210903
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -124,10 +123,12 @@ private[yarn] class YarnAllocator(
amClie
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4141#discussion_r24210363
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -192,15 +186,32 @@ private[yarn] class YarnAllocator(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4141#discussion_r24210327
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -192,15 +186,32 @@ private[yarn] class YarnAllocator(
}
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71593861
@lianhuiwang I am not sure I can comment on this PR. I am unfamiliar with
this piece of code.
---
If your project is set up for it, you can reply to this email and have yo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71550587
[Test build #26110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26110/consoleFull)
for PR 4141 at commit
[`472f944`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71550597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4141#discussion_r23564546
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -192,15 +186,32 @@ private[yarn] class YarnAllocator(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71537578
[Test build #26110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26110/consoleFull)
for PR 4141 at commit
[`472f944`](https://githu
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71537448
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71523335
just a minor comment, otherwise lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4141#discussion_r23557845
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
@@ -192,15 +186,32 @@ private[yarn] class YarnAllocator(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71401420
[Test build #26068 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26068/consoleFull)
for PR 4141 at commit
[`472f944`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71401422
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71399661
[Test build #26068 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26068/consoleFull)
for PR 4141 at commit
[`472f944`](https://githu
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71399452
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user lianhuiwang commented on the pull request:
https://github.com/apache/spark/pull/4141#issuecomment-71355510
LGTM, i think @tdas you can take a look at this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
28 matches
Mail list logo
