Github user petro-rudenko commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-75994711
Thanks, works now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-75992556
@petro-rudenko try a clean build. This changed code across modules.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user petro-rudenko commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-75989874
Having problem compiling spark with sbt due to next error:
```
$ build/sbt -Phadoop-2.4 compile
[error]
/home/peter/soft/spark_src/core/src/main/scala/or
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-75162138
I'm merging this into master and 1.3 thanks @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-75152626
[Test build #27737 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27737/consoleFull)
for PR 4514 at commit
[`5ed3a03`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-75152634
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4514#discussion_r25026972
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,9 +21,36 @@ package org.apache.spark.util
* An interface to represent clock
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-75137920
[Test build #27737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27737/consoleFull)
for PR 4514 at commit
[`5ed3a03`](https://githu
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4514#discussion_r25024948
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,9 +21,36 @@ package org.apache.spark.util
* An interface to represent clocks, s
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-75105136
Thanks @srowen this LGTM pending a few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4514#discussion_r25010352
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -21,9 +21,36 @@ package org.apache.spark.util
* An interface to represent clock
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4514#discussion_r25010289
--- Diff: core/src/main/scala/org/apache/spark/util/ManualClock.scala ---
@@ -17,10 +17,33 @@
package org.apache.spark.util
-class Fake
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74873746
@tdas I made the change less intrusive and added support for the old class
names in `spark.streaming.clock`. Is the streaming part OK with you?
---
If your project is set
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74867971
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74867967
[Test build #27681 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27681/consoleFull)
for PR 4514 at commit
[`169dd13`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74857803
[Test build #27681 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27681/consoleFull)
for PR 4514 at commit
[`169dd13`](https://githu
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74572557
I'll defer to @tdas's opinion for the streaming clock change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74554810
[Test build #27558 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27558/consoleFull)
for PR 4514 at commit
[`277785a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74554814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74543897
[Test build #27558 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27558/consoleFull)
for PR 4514 at commit
[`277785a`](https://githu
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74543422
@JoshRosen do you have an opinion on whether to go for this, or just remove
the easy two instances of Clock?
---
If your project is set up for it, you can reply to this e
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74439003
[Test build #27531 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27531/consoleFull)
for PR 4514 at commit
[`b5e53df`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74439013
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74435114
[Test build #27531 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27531/consoleFull)
for PR 4514 at commit
[`b5e53df`](https://githu
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74434987
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74432145
**[Test build #27527 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27527/consoleFull)**
for PR 4514 at commit
[`b5e53df`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74432148
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-74426607
[Test build #27527 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27527/consoleFull)
for PR 4514 at commit
[`b5e53df`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73866298
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73866288
[Test build #27289 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27289/consoleFull)
for PR 4514 at commit
[`324fffb`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73857523
[Test build #27289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27289/consoleFull)
for PR 4514 at commit
[`324fffb`](https://githu
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73855710
So the change to just remove two of the clocks is much smaller. If there's
any support for just bothering with that, this is a lot less bold. I'll proceed
for the moment l
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73828832
[Test build #27257 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27257/consoleFull)
for PR 4514 at commit
[`3136f4a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73828835
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4514#discussion_r24470877
--- Diff: core/src/main/scala/org/apache/spark/util/Clock.scala ---
@@ -22,8 +22,35 @@ package org.apache.spark.util
*/
private[spark] trait Clock {
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73824804
This is a very bold change. :)
* 10K feet comment - Isnt ManualClock more descriptive name than FakeClock?
* For other clocks, like the Clock in streaming, since those
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73823479
[Test build #27257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27257/consoleFull)
for PR 4514 at commit
[`3136f4a`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73820275
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73820269
[Test build #27248 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27248/consoleFull)
for PR 4514 at commit
[`a0d3985`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73812316
[Test build #27248 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27248/consoleFull)
for PR 4514 at commit
[`a0d3985`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73807882
[Test build #27242 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27242/consoleFull)
for PR 4514 at commit
[`15f6b0f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73807886
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73806765
[Test build #27242 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27242/consoleFull)
for PR 4514 at commit
[`15f6b0f`](https://githu
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/4514
SPARK-4682 [CORE] Consolidate various 'Clock' classes
Another one from @JoshRosen 's wish list. The first commit is much smaller
and removes 2 of the 4 Clock classes. The second is much larger, neces
45 matches
Mail list logo
