[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-08 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r73947457 --- Diff: python/pyspark/ml/classification.py --- @@ -44,6 +44,23 @@ @inherit_doc +class JavaClassificationModel(JavaPredictionModel):

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-08 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r73947897 --- Diff: python/pyspark/ml/classification.py --- @@ -44,6 +44,23 @@ @inherit_doc +class JavaClassificationModel(JavaPredictionModel):

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-10 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r74203267 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -788,6 +788,8 @@ class GeneralizedLinearRegressionMode

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-18 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r75385604 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -788,6 +788,8 @@ class GeneralizedLinearRegressionMod

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-18 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r75387160 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -788,6 +788,8 @@ class GeneralizedLinearRegressionMod

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-22 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r75633544 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -788,6 +788,8 @@ class GeneralizedLinearRegressionMode

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12889 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r75727539 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -788,6 +788,8 @@ class GeneralizedLinearRegressionModel

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-22 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r75728898 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -788,6 +788,8 @@ class GeneralizedLinearRegressionMode

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r75729345 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -788,6 +788,8 @@ class GeneralizedLinearRegressionModel

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-08-22 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r75735832 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -788,6 +788,8 @@ class GeneralizedLinearRegressionMode

[GitHub] spark pull request #12889: [SPARK-15113][PySpark][ML] Add missing num featur...

2016-07-20 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/12889#discussion_r71629288 --- Diff: python/pyspark/ml/classification.py --- @@ -581,8 +602,11 @@ def _create_model(self, java_model): @inherit_doc -class Decisio