[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-15 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r67259794 --- Diff: R/pkg/R/mllib.R --- @@ -402,6 +406,8 @@ setMethod("spark.naiveBayes", signature(data = "SparkDataFrame", formula = "form return(new(

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r67223092 --- Diff: R/pkg/R/mllib.R --- @@ -197,7 +201,7 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-13 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66917105 --- Diff: R/pkg/R/mllib.R --- @@ -197,7 +201,7 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741569 --- Diff: R/pkg/R/mllib.R --- @@ -218,9 +222,9 @@ setMethod("predict", signature(object = "GeneralizedLinearRegressionModel"), return(data

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741577 --- Diff: R/pkg/R/mllib.R --- @@ -582,9 +586,9 @@ setMethod("summary", signature(object = "AFTSurvivalRegressionModel"), return(list(coeff

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741575 --- Diff: R/pkg/R/mllib.R --- @@ -357,9 +361,9 @@ setMethod("summary", signature(object = "KMeansModel"), cluster = cluster, is.load

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741568 --- Diff: R/pkg/R/mllib.R --- @@ -197,7 +201,7 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741560 --- Diff: R/pkg/R/column.R --- @@ -170,6 +172,8 @@ setMethod("between", signature(x = "Column"), } }) +#' cast

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66741566 --- Diff: R/pkg/R/functions.R --- @@ -249,10 +249,7 @@ col <- function(x) { #' #' Returns a Column based on the given column name. #' -#'

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66719273 --- Diff: R/pkg/R/DataFrame.R --- @@ -851,6 +849,8 @@ setMethod("nrow", count(x) }) +#' ncol --- End diff --

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66719192 --- Diff: R/pkg/R/DataFrame.R --- @@ -2766,18 +2780,21 @@ setMethod("histogram", return(histStats) }) -#' Saves th

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66718939 --- Diff: R/pkg/R/DataFrame.R --- @@ -2766,18 +2780,21 @@ setMethod("histogram", return(histStats) }) -#' Saves th

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-12 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66718189 --- Diff: R/pkg/R/mllib.R --- @@ -197,11 +197,10 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-08 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66363113 --- Diff: R/pkg/R/mllib.R --- @@ -197,11 +197,10 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66357796 --- Diff: R/pkg/R/mllib.R --- @@ -197,11 +197,10 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-08 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66299402 --- Diff: R/pkg/R/mllib.R --- @@ -197,11 +197,10 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66182476 --- Diff: R/pkg/R/mllib.R --- @@ -197,11 +197,10 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66177097 --- Diff: R/pkg/R/mllib.R --- @@ -197,11 +197,10 @@ print.summary.GeneralizedLinearRegressionModel <- function(x, ...) { invisible(x) }

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66030853 --- Diff: R/pkg/R/functions.R --- @@ -249,6 +249,10 @@ col <- function(x) { #' #' Returns a Column based on the given column name. #' +

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66030066 --- Diff: R/pkg/R/DataFrame.R --- @@ -2766,18 +2780,21 @@ setMethod("histogram", return(histStats) }) -#' Saves

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66029758 --- Diff: R/pkg/R/DataFrame.R --- @@ -2766,18 +2780,21 @@ setMethod("histogram", return(histStats) }) -#' Saves

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66029614 --- Diff: R/pkg/R/DataFrame.R --- @@ -2173,20 +2182,22 @@ setMethod("except", dataFrame(excepted) }) -#' Save th

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66029225 --- Diff: R/pkg/R/DataFrame.R --- @@ -2046,6 +2054,7 @@ setMethod("merge", joinRes }) +#' generateAliasesForInte

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66029121 --- Diff: R/pkg/R/DataFrame.R --- @@ -851,6 +849,8 @@ setMethod("nrow", count(x) }) +#' ncol --- End diff --

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66028863 --- Diff: R/pkg/R/functions.R --- @@ -238,9 +238,9 @@ setMethod("ceil", column(jc) }) -#' Though scala functions

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-07 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r66019351 --- Diff: R/pkg/R/functions.R --- @@ -249,6 +249,10 @@ col <- function(x) { #' #' Returns a Column based on the given column name. #' +#' T

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65969103 --- Diff: R/pkg/R/functions.R --- @@ -249,6 +249,10 @@ col <- function(x) { #' #' Returns a Column based on the given column name. #' +#'

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-06 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65959598 --- Diff: R/pkg/R/DataFrame.R --- @@ -647,7 +645,7 @@ setMethod("toJSON", RDD(jrdd, serializedMode = "string") }) -

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-06 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65946137 --- Diff: R/pkg/R/stats.R --- @@ -135,13 +136,13 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"), #' Calculates the appr

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-06 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65849144 --- Diff: R/pkg/R/DataFrame.R --- @@ -628,8 +628,6 @@ setMethod("repartition", #' #' @param x A SparkDataFrame #' @return A StringRRDD of JSO

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-03 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65691008 --- Diff: R/pkg/R/DataFrame.R --- @@ -1069,6 +1079,8 @@ setMethod("first", #' #' @param x A SparkDataFrame #' +#' @family SparkDataFrame

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65656790 --- Diff: R/pkg/R/DataFrame.R --- @@ -1069,6 +1079,8 @@ setMethod("first", #' #' @param x A SparkDataFrame #' +#' @family SparkDataFram

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-01 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65483594 --- Diff: R/pkg/R/stats.R --- @@ -135,13 +136,13 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"), #' Calculates the ap

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-01 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65434586 --- Diff: R/pkg/R/stats.R --- @@ -135,13 +136,13 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"), #' Calculates the appro

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-01 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65418448 --- Diff: R/pkg/R/DataFrame.R --- @@ -2514,7 +2529,9 @@ setMethod("attach", #' environment. Then, the given expression is evaluated in this new #'

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65410850 --- Diff: R/pkg/R/stats.R --- @@ -135,13 +136,13 @@ setMethod("freqItems", signature(x = "SparkDataFrame", cols = "character"), #' Calculates the appr

[GitHub] spark pull request #13394: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs a...

2016-06-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13394#discussion_r65410753 --- Diff: R/pkg/R/DataFrame.R --- @@ -2514,7 +2529,9 @@ setMethod("attach", #' environment. Then, the given expression is evaluated in this new #'