[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70871119 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -359,6 +364,82 @@ public SparkLauncher setVerbose(boolean verbose) {

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70870990 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -455,6 +542,36 @@ private ProcessBuilder createBuilder() { for (

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70870422 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -82,8 +83,12 @@ /** Used internally to create unique logger names.

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70870174 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -359,6 +364,82 @@ public SparkLauncher setVerbose(boolean verbose) {

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70870046 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -359,6 +364,82 @@ public SparkLauncher setVerbose(boolean verbose) {

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70869756 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -82,8 +83,12 @@ /** Used internally to create unique logger names.

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70869464 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -455,6 +542,36 @@ private ProcessBuilder createBuilder() { for (

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/14201#discussion_r70869233 --- Diff: launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java --- @@ -52,6 +52,11 @@ final List pyFiles; final Map chil

[GitHub] spark pull request #14201: [SPARK-14702] Expose SparkLauncher's ProcessBuild...

2016-07-14 Thread andreweduffy
GitHub user andreweduffy opened a pull request: https://github.com/apache/spark/pull/14201 [SPARK-14702] Expose SparkLauncher's ProcessBuilder for user flexibility ## What changes were proposed in this pull request? Adds a few public methods to `SparkLauncher` to allow confi