Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r72131816
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -44,7 +50,11 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r72104591
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -44,7 +50,11 @@ import
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r72032682
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -58,10 +68,8 @@ case class CreateViewCommand(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r72032392
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -44,7 +50,11 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r72031776
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -44,7 +50,11 @@ import
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r72029905
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -44,7 +50,11 @@ import
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r72014267
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -44,7 +50,11 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71822672
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -88,23 +96,23 @@ case class CreateViewCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71821115
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -88,23 +96,23 @@ case class CreateViewCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71820977
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -88,23 +96,23 @@ case class CreateViewCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71819083
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -88,23 +96,23 @@ case class CreateViewCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71818729
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -88,23 +96,23 @@ case class CreateViewCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71818274
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -44,7 +50,11 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71816585
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -44,7 +50,11 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71816619
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -88,23 +96,23 @@ case class CreateViewCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71816553
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -88,23 +96,23 @@ case class CreateViewCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71767033
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -44,7 +50,11 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71764709
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -88,23 +96,23 @@ case class CreateViewCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71763014
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -88,23 +96,23 @@ case class CreateViewCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71762438
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1271,23 +1272,23 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14297#discussion_r71761490
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2438,12 +2441,15 @@ class Dataset[T] private[sql](
* @since 2.0.0
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/14297
[SPARK-16660][SQL] CreateViewCommand should not take CatalogTable
## What changes were proposed in this pull request?
`CreateViewCommand` only needs some information of a `CatalogTable`,
23 matches
Mail list logo
