[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14615 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r115880909 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -1326,6 +1327,17 @@ class JsonSuite extends

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r115880769 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2828,9 +2828,7 @@ class Dataset[T] private[sql]( json

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r115819950 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2717,8 +2718,6 @@ class Dataset[T] private[sql]( } }

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r115819564 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2692,9 +2692,10 @@ class Dataset[T] private[sql]( * @since 2.0.0

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user robert3005 commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r74789001 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2494,16 +2494,18 @@ class Dataset[T] private[sql]( * @since 2.0.0

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user robert3005 commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r74788858 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala --- @@ -84,7 +84,7 @@ class JsonFileFormat

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r74547724 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala --- @@ -84,7 +84,7 @@ class JsonFileFormat extends

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r74547742 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2494,16 +2494,18 @@ class Dataset[T] private[sql]( * @since 2.0.0

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r74547698 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala --- @@ -155,13 +155,13 @@ class JsonFileFormat extends

[GitHub] spark pull request #14615: [SPARK-17029] make toJSON not go through rdd form...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14615#discussion_r7454 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2494,16 +2494,18 @@ class Dataset[T] private[sql]( * @since 2.0.0