GitHub user clockfly opened a pull request:
https://github.com/apache/spark/pull/14723
[SQL][WIP][Test] Supports object-based aggregation function which can store
arbitrary objects in aggregation buffer.
## What changes were proposed in this pull request
This PR allows user
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586183
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarative
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586233
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarative
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586232
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarative
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586238
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarative
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586350
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarative
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586622
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarative
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586661
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarative
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarative
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586764
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarative
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75586776
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/AggregateWithObjectAggregateBufferSuite.scala
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apa
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75612521
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declara
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75612644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declar
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75612665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarat
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75613381
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declara
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75613439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declara
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75613492
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declara
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75613743
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala
---
@@ -90,6 +98,21 @@ class SortBasedAggreg
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75613875
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/AggregateWithObjectAggregateBufferSuite.scala
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75622002
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/AggregateWithObjectAggregateBufferSuite.scala
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75622250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,89 @@ abstract class Declarat
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75622311
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala
---
@@ -90,6 +98,21 @@ class SortBasedAggrega
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75632667
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -389,3 +389,126 @@ abstract class Declar
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75641493
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala
---
@@ -90,6 +98,21 @@ class SortBasedAggre
Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75688342
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/AggregateWithObjectAggregateBufferSuite.scala
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75700385
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/AggregateWithObjectAggregateBufferSuite.scala
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the
Github user clockfly closed the pull request at:
https://github.com/apache/spark/pull/14723
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
27 matches
Mail list logo
