Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user sumansomasundar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r79790720
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache So
Github user sumansomasundar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r79790670
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -40,24 +41,41 @@ public static int roundNumberOfByt
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r79575764
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -40,24 +41,41 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r79574344
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Fo
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r79575057
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -40,24 +41,41 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r79282710
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -40,24 +41,41 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r79135820
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Fo
Github user jlhitt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78988242
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,20 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78986374
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,20 @@ public static int roundNumberOfBytesToNeare
Github user jlhitt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78985465
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,20 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78981296
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,20 @@ public static int roundNumberOfBytesToNeare
Github user jlhitt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78979436
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -46,6 +47,7 @@ private[columnar]
Github user jlhitt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78978059
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,20 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78975745
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -46,6 +47,7 @@ private[columnar]
Github user jlhitt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78975107
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -699,9 +703,10 @@ public boolean append(Object kbase, long koff, int
kle
Github user jlhitt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78974821
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -46,6 +47,7 @@ private[columnar]
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78909202
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -699,9 +703,10 @@ public boolean append(Object kbase, long koff, int
kle
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78909063
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -46,6 +47,7 @@ private[columnar]
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78908926
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,20 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78707472
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Fo
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78707769
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -699,9 +703,10 @@ public boolean append(Object kbase, long koff, int
kle
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78707672
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,20 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78707430
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Fo
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78707580
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Fo
Github user sumansomasundar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r78636130
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -61,8 +63,12 @@ private
Github user sumansomasundar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77755718
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,20 @@ public static int roundNumberOfByt
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77308494
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -61,8 +63,12 @@ private[columnar
Github user sumansomasundar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77304811
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -61,8 +63,12 @@ private
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77049945
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -61,8 +63,12 @@ private[columnar
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77049780
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -46,6 +47,7 @@ private[columnar]
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77049534
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,20 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77049254
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Fo
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77049357
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Fo
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r77049138
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Fo
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r75811895
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/CompressibleColumnBuilder.scala
---
@@ -61,8 +63,16 @@ private[columnar
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r75811832
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,50 @@
+/*
+ * Class to make changes to record le
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r75811782
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -47,13 +47,19 @@ public static int roundNumberOfBytesToNeare
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r75811759
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,50 @@
+/*
+ * Class to make changes to record le
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r75811715
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,50 @@
+/*
+ * Class to make changes to record le
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r75811674
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,50 @@
+/*
+ * Class to make changes to record le
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r75811646
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,50 @@
+/*
+ * Class to make changes to record le
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14762#discussion_r75811636
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java ---
@@ -0,0 +1,50 @@
+/*
--- End diff --
There are a n
GitHub user sumansomasundar opened a pull request:
https://github.com/apache/spark/pull/14762
[SPARK-16962][CORE][SQL] Fix misaligned record accesses for SPARC
architectures
## What changes were proposed in this pull request?
Made changes to record length offsets to make th
44 matches
Mail list logo
