[GitHub] spark pull request #15596: [SPARK-18089][SQL] Remove CollectLimitExec

2016-10-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15596#discussion_r85264043 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala --- @@ -27,32 +27,14 @@ import org.apache.spark.sql.execution.exchange.ShuffleEx

[GitHub] spark pull request #15596: [SPARK-18089][SQL] Remove CollectLimitExec

2016-10-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15596#discussion_r85049115 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -298,6 +298,12 @@ case class WholeStageCodegenExec(child:

[GitHub] spark pull request #15596: [SPARK-18089][SQL] Remove CollectLimitExec

2016-10-24 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15596#discussion_r84838595 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -298,6 +298,12 @@ case class WholeStageCodegenExec(child: S