Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r99527096
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
@@ -354,31 +354,58 @@ class DateFunctionsSuite extends QueryTest with
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r99371741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1047,6 +1048,69 @@ case class ToDate(chi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r99308570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1047,6 +1048,69 @@ case class ToDate(chi
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r99283708
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1047,6 +1048,64 @@ case class ToDate(chi
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r99278789
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -1177,6 +1177,9 @@ test_that("column functions", {
c17 <- cov(c, c1) + cov("c", "c1") + co
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r99278746
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1047,6 +1048,64 @@ case class ToDate(chi
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r99278738
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1047,6 +1048,64 @@ case class ToDate(chi
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r99278624
--- Diff: R/pkg/R/functions.R ---
@@ -1746,7 +1750,7 @@ setMethod("toRadians",
#' to_date(df$c)
#' to_date(df$c, '-MM-dd')
#' }
-#' @
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97976102
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1047,6 +1048,64 @@ case class ToDate(chi
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97493826
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -1177,6 +1177,9 @@ test_that("column functions", {
c17 <- cov(c, c1) + cov("c", "c1") +
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97492683
--- Diff: R/pkg/R/functions.R ---
@@ -1746,7 +1750,7 @@ setMethod("toRadians",
#' to_date(df$c)
#' to_date(df$c, '-MM-dd')
#' }
-#'
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97490239
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1047,6 +1048,64 @@ case class ToDate(chi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97489950
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1047,6 +1048,64 @@ case class ToDate(chi
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97470798
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97470763
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97470784
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97470589
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97470513
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97469354
--- Diff: R/pkg/R/generics.R ---
@@ -1274,6 +1270,14 @@ setGeneric("unbase64", function(x) {
standardGeneric("unbase64") })
#' @export
setGeneric
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97469259
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97469263
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97463208
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97463181
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97463093
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97463139
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97462936
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97462770
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97462585
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97462348
--- Diff: R/pkg/R/generics.R ---
@@ -1274,6 +1270,14 @@ setGeneric("unbase64", function(x) {
standardGeneric("unbase64") })
#' @export
setGener
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97462223
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r97462284
--- Diff: R/pkg/R/functions.R ---
@@ -1730,24 +1730,82 @@ setMethod("toRadians",
#' to_date
#'
-#' Converts the column into DateType.
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r96722604
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1047,6 +1048,60 @@ case class ToDate(ch
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16138#discussion_r9670
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -389,6 +389,20 @@ class DateExpressions
34 matches
Mail list logo
