[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99578597 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -374,25 +375,24 @@ case class

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99401502 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala --- @@ -80,13 +80,17 @@ class DetermineHiveSerde(conf: SQLConf) extends

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99401545 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -45,7 +45,8 @@ import

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99398131 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -20,15 +20,23 @@ package

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99397551 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -374,25 +375,24 @@ case class

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99397097 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -20,15 +20,23 @@ package

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99394934 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala --- @@ -273,10 +285,6 @@ object DataSourceStrategy

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99394346 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -405,32 +405,4 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99394101 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -405,32 +405,4 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99393848 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -405,32 +405,4 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99393281 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -363,7 +363,8 @@ case class

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99391911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -376,28 +376,6 @@ trait CheckAnalysis extends

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99391020 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -413,6 +391,10 @@ trait CheckAnalysis extends

[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16269#discussion_r99390405 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -376,28 +376,6 @@ trait CheckAnalysis extends