Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93814369
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -143,15 +197,96 @@ case class TypedAggregate
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93813855
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -143,15 +197,96 @@ case class TypedAggreg
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93813849
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -143,15 +197,96 @@ case class TypedAggreg
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93812875
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -143,15 +197,96 @@ case class TypedAggregate
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93812727
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -143,15 +197,96 @@ case class TypedAggregate
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93768760
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -143,15 +197,96 @@ case class TypedAggregate
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93768656
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -143,15 +197,96 @@ case class TypedAggreg
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93768546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -505,19 +511,18 @@ abstract class TypedImpe
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93768139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -505,19 +511,18 @@ abstract class TypedI
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93725196
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -143,15 +197,96 @@ case class TypedAggregate
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93724428
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -505,19 +511,18 @@ abstract class TypedImpe
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93724370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -471,23 +471,29 @@ abstract class TypedImpe
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93650127
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -192,14 +192,14 @@ object DatasetBenchmark {
benchmark2.run()
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93649298
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -471,23 +471,29 @@ abstract class TypedI
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93633604
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -192,14 +192,14 @@ object DatasetBenchmark {
benchmark2.run()
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93631593
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -471,23 +471,29 @@ abstract class TypedImpe
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93627963
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -192,14 +192,14 @@ object DatasetBenchmark {
benchmark2.run()
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93627580
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -471,23 +471,29 @@ abstract class TypedI
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93622607
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -192,14 +192,14 @@ object DatasetBenchmark {
benchmark2.run()
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93619384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -471,23 +471,29 @@ abstract class TypedImpe
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16383#discussion_r93613580
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -192,14 +192,14 @@ object DatasetBenchmark {
benchmark2.run()
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/16383
[SPARK-18980][SQL] implement Aggregator with TypedImperativeAggregate
## What changes were proposed in this pull request?
Currently we implement `Aggregator` with `DeclarativeAggregate`,
23 matches
Mail list logo
