[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97213829 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -168,6 +168,43 @@ case class AlterTableRenameCommand( }

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97213702 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -584,14 +593,18 @@ private[spark] class HiveExternalCatalog(conf

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97213578 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java --- @@ -107,7 +107,13 @@ public voi

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97212553 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -736,6 +736,22 @@ class SparkSqlAstBuilder(conf: SQLConf) extends

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97195490 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -584,14 +593,18 @@ private[spark] class HiveExternalCatalog(conf:

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97195247 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -168,6 +168,43 @@ case class AlterTableRenameCommand( }

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97192776 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java --- @@ -107,7 +107,13 @@ public void

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97191587 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -168,6 +168,43 @@ case class AlterTableRenameCommand( }

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97191445 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -814,4 +814,28 @@ object DDLUtils { } }

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97191366 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -814,4 +814,28 @@ object DDLUtils { } }

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97189715 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -168,6 +168,43 @@ case class AlterTableRenameCommand( }

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97189688 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -814,4 +814,28 @@ object DDLUtils { } }

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97174715 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -168,6 +168,43 @@ case class AlterTableRenameCommand( }

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16626#discussion_r97174479 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -736,6 +736,21 @@ class SparkSqlAstBuilder(conf: SQLConf) ext

[GitHub] spark pull request #16626: [SPARK-19261][SQL] Alter add columns for Hive tab...

GitHub user xwu0226 opened a pull request: https://github.com/apache/spark/pull/16626 [SPARK-19261][SQL] Alter add columns for Hive tables ## What changes were proposed in this pull request? Support ALTER TABLE ADD COLUMNS (...) syntax for Hive tables. In this PR, we conside