[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100255729 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -213,6 +218,24 @@ class SparkSession private( new SparkSession(sparkC

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100192972 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala --- @@ -38,16 +38,31 @@ import org.apache.spark.sql.util.ExecutionListen

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100197297 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -213,6 +218,24 @@ class SparkSession private( new SparkSession(spa

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100195293 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -213,6 +218,24 @@ class SparkSession private( new SparkSession(spa

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100190232 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/ExperimentalMethods.scala --- @@ -46,4 +48,23 @@ class ExperimentalMethods private[sql]() {

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100195235 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -213,6 +218,24 @@ class SparkSession private( new SparkSession(spa

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100193350 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala --- @@ -38,16 +38,31 @@ import org.apache.spark.sql.util.ExecutionListen

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100194991 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala --- @@ -151,7 +155,7 @@ private[hive] class TestHiveSparkSession( n

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100195109 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -213,6 +218,24 @@ class SparkSession private( new SparkSession(spa

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100195324 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -213,6 +218,24 @@ class SparkSession private( new SparkSession(spa

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100198503 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala --- @@ -123,4 +125,70 @@ class SparkSessionBuilderSuite extends SparkF

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100194351 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala --- @@ -65,12 +80,29 @@ private[sql] class SessionState(sparkSession: Sp

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16826#discussion_r100194640 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala --- @@ -115,16 +113,22 @@ class TestHiveContext( private[hive] class Te

[GitHub] spark pull request #16826: Fork SparkSession with option to inherit a copy o...

2017-02-06 Thread kunalkhamar
GitHub user kunalkhamar opened a pull request: https://github.com/apache/spark/pull/16826 Fork SparkSession with option to inherit a copy of the SessionState. ## What changes were proposed in this pull request? Forking a newSession() from SparkSession currently makes a new S