[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16864 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-10 Thread Bcpoole
Github user Bcpoole commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100624882 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilterImpl.java --- @@ -221,6 +221,49 @@ public BloomFilter mergeInPlace(BloomFilte

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-10 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100569750 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java --- @@ -81,6 +81,11 @@ int getVersionNumber() { public abstract lo

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-10 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100571446 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java --- @@ -148,6 +153,24 @@ int getVersionNumber() { public abstract

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-10 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100571673 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilterImpl.java --- @@ -221,6 +221,49 @@ public BloomFilter mergeInPlace(BloomFilter

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-10 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100570007 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java --- @@ -81,6 +81,11 @@ int getVersionNumber() { public abstract lo

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100503141 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java --- @@ -81,6 +81,11 @@ int getVersionNumber() { public abstract long

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-09 Thread Bcpoole
Github user Bcpoole commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100385258 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java --- @@ -81,6 +81,11 @@ int getVersionNumber() { public abstract l

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-09 Thread Bcpoole
Github user Bcpoole commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100381372 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/IncompatibleUnionException.java --- @@ -0,0 +1,24 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100261227 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java --- @@ -81,6 +81,11 @@ int getVersionNumber() { public abstract long

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100261151 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java --- @@ -148,6 +153,20 @@ int getVersionNumber() { public abstract bo

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-09 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100261088 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/IncompatibleUnionException.java --- @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-08 Thread Bcpoole
GitHub user Bcpoole opened a pull request: https://github.com/apache/spark/pull/16864 [SPARK-19527][Core] Approximate Size of Intersection of Bloom Filters **What changes were proposed in this pull request?** Added functions to get the Swamidass & Baldi (2007) approximation