[GitHub] spark pull request #17014: [SPARK-18608][ML][WIP] Fix double-caching in ML a...

2017-02-21 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17014#discussion_r102262826 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala --- @@ -126,9 +129,10 @@ abstract class Predictor[ * and copying parameters into

[GitHub] spark pull request #17014: [SPARK-18608][ML][WIP] Fix double-caching in ML a...

2017-02-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17014#discussion_r102205041 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala --- @@ -126,9 +129,10 @@ abstract class Predictor[ * and copying parameters into

[GitHub] spark pull request #17014: [SPARK-18608][ML][WIP] Fix double-caching in ML a...

2017-02-21 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/17014 [SPARK-18608][ML][WIP] Fix double-caching in ML algorithms ## What changes were proposed in this pull request? 1, For Predictors, use `train(dataset: Dataset[_], handlePersistence: