GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/17125
[SPARK-19211][SQL] Explicitly prevent Insert into View or Create View As
Insert
## What changes were proposed in this pull request?
Currently we don't explicitly forbid the following b
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103858555
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,14 @@ class Analyzer(
def
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103858997
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103858978
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103859056
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.a
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103860095
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.as
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103860516
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103863369
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.as
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103863856
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103865408
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.as
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103891636
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.a
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103891768
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,14 @@ class Analyzer(
def
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103892046
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
qe.a
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103978808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,13 @@ class Analyzer(
def
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103984820
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,13 @@ class Analyzer(
def
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104121538
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,13 @@ class Analyzer(
def
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104157426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,13 @@ class Analyzer(
def
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104210022
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
@@ -484,6 +485,23 @@ abstract class SQLViewSuite extends QueryTes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104210054
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
@@ -484,6 +485,23 @@ abstract class SQLViewSuite extends QueryTes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104210669
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
@@ -484,6 +485,23 @@ abstract class SQLViewSuite extends QueryTes
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104211285
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1329,6 +1329,16 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104211301
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1329,6 +1329,16 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104280410
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1329,6 +1329,15 @@ class SparkSqlAstBuilder(conf: SQLConf) e
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104280434
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,7 @@ class Analyzer(
def ap
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104280480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1329,6 +1329,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104280528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,7 @@ class Analyzer(
def
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104281300
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1329,6 +1329,15 @@ class SparkSqlAstBuilder(conf: SQLConf) e
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104281325
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,7 @@ class Analyzer(
def ap
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104284763
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1329,6 +1329,15 @@ class SparkSqlAstBuilder(conf: SQLConf)
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104284787
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,7 @@ class Analyzer(
def
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104329721
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,7 @@ class Analyzer(
def ap
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104338208
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,13 @@ class Analyzer(
def
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104345227
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,13 @@ class Analyzer(
def
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r104345660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,13 @@ class Analyzer(
def
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
35 matches
Mail list logo
