Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113860946
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,27 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113859742
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,27 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113742821
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113739936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113683028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113679144
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113651165
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113645978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113645161
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113640869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113638348
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113600909
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113600878
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113599279
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113598257
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113598310
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113598206
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -998,6 +998,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113365310
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -136,6 +136,7 @@ class Analyzer(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113360559
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -136,6 +136,7 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r113351326
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -136,6 +136,7 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112605454
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -136,6 +136,7 @@ class Analyzer(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112603375
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -136,6 +136,7 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112595036
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1005,6 +1005,31 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112594814
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1005,6 +1005,31 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112173197
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -161,6 +161,8 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112168787
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,26 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112168719
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,31 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112152324
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -161,6 +161,8 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112141941
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,31 @@ class Analyzer(
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112135554
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,31 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112126273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,22 @@ class Analyzer(
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112126028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112125706
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,26 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112125524
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112116955
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,22 @@ class Analyzer(
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112115780
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,26 @@ class Analyzer(
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112115405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,22 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112114553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,26 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112114110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1003,6 +1009,8 @@ class SQLConf extends Serializable with Logging
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112111971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,26 @@ class Analyzer(
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112111734
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1003,6 +1009,8 @@ class SQLConf extends Serializable with Logging
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112110655
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -161,6 +161,8 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112109737
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -421,6 +421,12 @@ object SQLConf {
.booleanConf
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112106597
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -35,3 +35,18 @@ FROM testData;
-- Aggregate with foldable input and
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112109609
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
---
@@ -164,7 +164,7 @@ class AnalysisErrorSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112107602
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -161,6 +161,8 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112106251
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -161,6 +161,8 @@ class Analyzer(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112105346
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -35,3 +35,18 @@ FROM testData;
-- Aggregate with foldable input and
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112105286
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
---
@@ -164,7 +164,7 @@ class AnalysisErrorSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112105230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -421,6 +421,12 @@ object SQLConf {
.booleanConf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112105172
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -161,6 +161,8 @@ class Analyzer(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112105086
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,26 @@ class Analyzer(
}
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r111951716
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,30 @@ class Analyzer(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r111943766
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,30 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r107083369
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,30 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r107080177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,30 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r107072663
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
---
@@ -164,7 +164,7 @@ class AnalysisErrorSuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r107068209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,30 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r107067691
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
---
@@ -164,7 +164,7 @@ class AnalysisErrorSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r107066194
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,30 @@ class Analyzer(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r106814663
--- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql ---
@@ -35,3 +35,6 @@ FROM testData;
-- Aggregate with foldable input and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r106814321
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2598,4 +2598,27 @@ class SQLQuerySuite extends QueryTest with
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r106770623
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2598,4 +2598,26 @@ class SQLQuerySuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r106717092
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2598,4 +2598,26 @@ class SQLQuerySuite extends QueryTest with
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r106621654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,29 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r106607806
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,29 @@ class Analyzer(
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r106540691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,29 @@ class Analyzer(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r106096009
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2586,4 +2586,15 @@ class SQLQuerySuite extends QueryTest with
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r105659975
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2586,4 +2586,15 @@ class SQLQuerySuite extends QueryTest with
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r105679116
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -775,11 +775,21 @@ class Analyzer(
case
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/17191
[SPARK-14471][SQL] Aliases in SELECT could be used in GROUP BY
## What changes were proposed in this pull request?
This pr added a new rule in `Analyzer` to resolve aliases in `GROUP BY`.
72 matches
Mail list logo
