[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17452 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-31 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r109116625 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-31 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r109092653 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-30 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r109072645 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-30 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108978377 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108978223 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108977947 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108976857 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-30 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108969951 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108898852 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-30 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108898299 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108885749 --- Diff: dev/make-distribution.sh --- @@ -217,43 +217,43 @@ fi # Make R package - this is used for both CRAN release and packing R layout into

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-29 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108623175 --- Diff: R/check-cran.sh --- @@ -40,7 +40,7 @@ fi if [ -d "$SPARK_JARS_DIR" ]; then # Build a zip file containing the source package

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108407452 --- Diff: R/check-cran.sh --- @@ -20,14 +20,14 @@ set -o pipefail set -e -FWDIR="$(cd `dirname "${BASH_SOURCE[0]}"`; pwd)" -pushd

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-28 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108400132 --- Diff: R/check-cran.sh --- @@ -20,14 +20,14 @@ set -o pipefail set -e -FWDIR="$(cd `dirname "${BASH_SOURCE[0]}"`; pwd)"

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108363062 --- Diff: R/check-cran.sh --- @@ -40,7 +40,7 @@ fi if [ -d "$SPARK_JARS_DIR" ]; then # Build a zip file containing the source package with

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108360431 --- Diff: R/check-cran.sh --- @@ -20,14 +20,14 @@ set -o pipefail set -e -FWDIR="$(cd `dirname "${BASH_SOURCE[0]}"`; pwd)" -pushd