[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109605638 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -766,6 +771,31 @@ object PushDownPredicate extends Rule

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109604178 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1032,6 +1251,109 @@ object PushPredicateThroughJoin ex

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109603467 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1032,6 +1251,109 @@ object PushPredicateThroughJoin ex

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109521220 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -848,11 +967,84 @@ object PushDownPredicate extends Rule

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109521143 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -823,9 +890,61 @@ object PushDownPredicate extends Rule[

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109522976 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -474,9 +478,42 @@ case class EliminateOuterJoin(conf: Cataly

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109519783 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -792,6 +824,39 @@ object PushDownPredicate extends Rule[

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109519728 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -766,6 +771,31 @@ object PushDownPredicate extends Rule[

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109522412 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1032,6 +1248,109 @@ object PushPredicateThroughJoin ext

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109521667 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -848,11 +967,84 @@ object PushDownPredicate extends Rule

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109521264 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -848,11 +967,84 @@ object PushDownPredicate extends Rule

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
Github user nsyca commented on a diff in the pull request: https://github.com/apache/spark/pull/17520#discussion_r109522050 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -792,6 +824,39 @@ object PushDownPredicate extends Rule[

[GitHub] spark pull request #17520: [WIP][SPARK-19712][SQL] Move PullupCorrelatedPred...

2017-04-03 Thread nsyca
GitHub user nsyca opened a pull request: https://github.com/apache/spark/pull/17520 [WIP][SPARK-19712][SQL] Move PullupCorrelatedPredicates and RewritePredicateSubquery after OptimizeSubqueries ## What changes were proposed in this pull request? This commit moves two rules right