Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115394606
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -441,4 +440,15 @@ class AnalysisSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115394532
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -57,19 +57,21 @@ object
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115394355
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -78,37 +80,52 @@ object
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115375986
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -498,12 +498,16 @@ case class Sort(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115375400
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -441,4 +440,15 @@ class AnalysisSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115375162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -57,19 +57,21 @@ object
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115374896
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,15 +472,19 @@ identifierComment
;
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115361494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -57,19 +57,21 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115361167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -57,19 +57,21 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115358211
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -441,4 +440,15 @@ class AnalysisSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115357687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -498,12 +498,16 @@ case class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115320568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -78,37 +80,52 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115318006
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -78,37 +80,52 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115317931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -78,37 +80,52 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115297323
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,15 +472,19 @@ identifierComment
;
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115296724
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -69,7 +69,10 @@ case class UnresolvedInlineTable(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r111955658
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,11 +472,11 @@ identifierComment
;
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r111955189
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,11 +472,11 @@ identifierComment
;
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r111952174
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,11 +472,11 @@ identifierComment
;
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r111951527
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,11 +472,11 @@ identifierComment
;
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r111951160
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,11 +472,11 @@ identifierComment
;
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r111950902
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,11 +472,11 @@ identifierComment
;
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/17666
[SPARK-20311][SQL] Support aliases for table value functions
## What changes were proposed in this pull request?
This pr added parsing rules to support aliases in table value functions.
24 matches
Mail list logo
