[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-21 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r112736608 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -1149,6 +1300,49 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113048193 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -434,8 +587,45 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113067669 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -546,6 +736,21 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113047003 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -324,6 +460,18 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113065566 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -434,8 +587,45 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113071333 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -650,6 +711,34 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113070161 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -610,6 +639,38 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113042705 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -178,6 +179,68 @@ private[classification] trait LogisticRe

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113042111 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -178,6 +179,68 @@ private[classification] trait LogisticRe

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113066007 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -434,8 +587,45 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113073040 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -815,6 +904,40 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113073212 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -1149,6 +1300,49 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113072397 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -1149,6 +1300,49 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-24 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113052881 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -434,8 +587,45 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113650727 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -610,6 +639,38 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r113652694 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -1149,6 +1300,49 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r114030627 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -178,11 +178,86 @@ private[classification] trait Logis

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r114032804 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -312,6 +390,71 @@ class LogisticRegression @Since("1.2.

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r114030750 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -178,11 +178,86 @@ private[classification] trait Logis

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r114031122 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -178,11 +178,86 @@ private[classification] trait Logis

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r114032822 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -312,6 +390,71 @@ class LogisticRegression @Since("1.2.

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r114032643 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -312,6 +390,71 @@ class LogisticRegression @Since("1.2.

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-04-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r114030799 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -178,11 +178,86 @@ private[classification] trait Logis

[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

2017-05-01 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17715#discussion_r114248399 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -178,11 +178,86 @@ private[classification] trait Logi