[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread zero323
GitHub user zero323 opened a pull request: https://github.com/apache/spark/pull/17783 [SPARK-20490][SPARKR][WIP] Add R wrappers for eqNullSafe and ! / not. ## What changes were proposed in this pull request? - Add null-safe equality operator `%<=>%` (sames as `o.a.s.sql.Col

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113753986 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,41 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions",

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113754078 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,65 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value)

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113772682 --- Diff: R/pkg/R/functions.R --- @@ -3803,3 +3803,41 @@ setMethod("repeat_string", jc <- callJStatic("org.apache.spark.sql.functions", "rep

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113773816 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,65 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value) colu

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113777544 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,65 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value) colu

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849107 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,65 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value)

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849582 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1965,6 +1975,16 @@ test_that("filter() on a DataFrame", { # Test stats::filter i

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849285 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,65 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value)

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849536 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1478,6 +1481,13 @@ test_that("column functions", { lapply( list(list(x =

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113849200 --- Diff: R/pkg/R/column.R --- @@ -67,8 +67,7 @@ operators <- list( "+" = "plus", "-" = "minus", "*" = "multiply", "/" = "divide", "%%" = "mod",

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-28 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113927479 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,65 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value) colu

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-28 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113991432 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -1478,6 +1481,13 @@ test_that("column functions", { lapply( list(list(x = 1, y

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-28 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r113992412 --- Diff: R/pkg/R/column.R --- @@ -67,8 +67,7 @@ operators <- list( "+" = "plus", "-" = "minus", "*" = "multiply", "/" = "divide", "%%" = "mod",

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r114058191 --- Diff: R/pkg/R/column.R --- @@ -67,8 +67,7 @@ operators <- list( "+" = "plus", "-" = "minus", "*" = "multiply", "/" = "divide", "%%" = "mod",

[GitHub] spark pull request #17783: [SPARK-20490][SPARKR][WIP] Add R wrappers for eqN...

2017-04-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17783#discussion_r114067173 --- Diff: R/pkg/R/column.R --- @@ -302,3 +301,56 @@ setMethod("otherwise", jc <- callJMethod(x@jc, "otherwise", value)