Github user leliang65 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r182644949
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBucketizerExample.java
---
@@ -33,6 +33,13 @@
import org.apache.spark.sql.types.St
Github user tengpeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r152891005
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -108,26 +164,53 @@ final class Bucketizer @Since("1.4.0")
(@Since("1.4.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17819
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143947510
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -187,6 +188,196 @@ class BucketizerSuite extends SparkFunSuite with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143947158
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBucketizerExample.java
---
@@ -33,6 +33,13 @@
import org.apache.spark.sql.types.Struc
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143930542
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -96,9 +99,71 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
o
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143929154
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -96,9 +99,71 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
o
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143926137
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -24,20 +24,23 @@ import org.apache.spark.annotation.Since
import org.
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143733664
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -96,9 +99,71 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
o
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143730103
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -187,6 +188,196 @@ class BucketizerSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143728145
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -96,9 +99,71 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
o
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143724079
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -187,6 +188,196 @@ class BucketizerSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143728324
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -187,6 +188,196 @@ class BucketizerSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143728663
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -187,6 +188,196 @@ class BucketizerSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143710289
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -96,9 +99,71 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
o
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143724681
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -187,6 +188,196 @@ class BucketizerSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143730302
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -187,6 +188,196 @@ class BucketizerSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143730685
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -24,20 +24,23 @@ import org.apache.spark.annotation.Since
import org.
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143722947
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BucketizerSuite.scala ---
@@ -187,6 +188,196 @@ class BucketizerSuite extends SparkFunSuite with
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143708258
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -24,20 +24,23 @@ import org.apache.spark.annotation.Since
import org.
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143712667
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -108,26 +173,53 @@ final class Bucketizer @Since("1.4.0")
(@Since("1.4.0"
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143713315
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaBucketizerExample.java
---
@@ -33,6 +33,13 @@
import org.apache.spark.sql.types.Struc
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143723205
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -96,9 +99,71 @@ final class Bucketizer @Since("1.4.0") (@Since("1.4.0")
o
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143707170
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -684,6 +684,34 @@ class DataFrameSuite extends QueryTest with
SharedSQLCo
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r143706308
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -684,6 +684,34 @@ class DataFrameSuite extends QueryTest with
SharedSQLCo
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r142278786
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2120,6 +2120,19 @@ class Dataset[T] private[sql](
}
/**
+
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r142278697
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2120,6 +2120,19 @@ class Dataset[T] private[sql](
}
/**
+
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r142278563
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2120,6 +2120,19 @@ class Dataset[T] private[sql](
}
/**
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r142278414
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2120,6 +2120,19 @@ class Dataset[T] private[sql](
}
/**
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r142172037
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,55 @@ class Dataset[T] private[sql](
}
/**
+
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17819#discussion_r139729964
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2102,6 +2102,53 @@ class Dataset[T] private[sql](
}
/**
+
31 matches
Mail list logo
