[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-07-13 Thread zero323
Github user zero323 closed the pull request at: https://github.com/apache/spark/pull/17922 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-07-11 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r126767873 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -170,6 +170,15 @@ def toVector(value): raise TypeError("Could not convert %s to

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-07-11 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r126765747 --- Diff: python/pyspark/ml/classification.py --- @@ -246,18 +246,55 @@ class LogisticRegression(JavaEstimator, HasFeaturesCol, HasLabelCol,

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-07-11 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r126769478 --- Diff: python/pyspark/ml/tests.py --- @@ -832,6 +860,96 @@ def test_logistic_regression(self): except OSError: pass

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-07-11 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r126766060 --- Diff: python/pyspark/ml/classification.py --- @@ -246,18 +246,55 @@ class LogisticRegression(JavaEstimator, HasFeaturesCol, HasLabelCol,

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-06-23 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r123769816 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -170,6 +170,15 @@ def toVector(value): raise TypeError("Could not convert %s to vector"

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-06-23 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r123768466 --- Diff: python/pyspark/ml/tests.py --- @@ -832,6 +860,96 @@ def test_logistic_regression(self): except OSError: pass

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-06-23 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r123766355 --- Diff: python/pyspark/ml/tests.py --- @@ -832,6 +860,96 @@ def test_logistic_regression(self): except OSError: pass

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-06-23 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r123765079 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -170,6 +170,15 @@ def toVector(value): raise TypeError("Could not convert %s to vector" %

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-06-23 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r123707614 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -170,6 +170,15 @@ def toVector(value): raise TypeError("Could not convert %s to vector"

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-06-23 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r123711301 --- Diff: python/pyspark/ml/tests.py --- @@ -832,6 +860,96 @@ def test_logistic_regression(self): except OSError: pass

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-06-03 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r119992981 --- Diff: python/pyspark/ml/tests.py --- @@ -819,6 +847,84 @@ def logistic_regression_check_thresholds(self): LogisticRegression,

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-05-09 Thread zero323
Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r11267 --- Diff: python/pyspark/ml/classification.py --- @@ -374,6 +415,48 @@ def getFamily(self): """ return

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-05-09 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r115497704 --- Diff: python/pyspark/ml/tests.py --- @@ -71,6 +71,34 @@ ser = PickleSerializer() +def generate_multinomial_logistic_input( +

[GitHub] spark pull request #17922: [SPARK-20601][PYTHON][ML] Python API Changes for ...

2017-05-09 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/17922#discussion_r115497473 --- Diff: python/pyspark/ml/classification.py --- @@ -374,6 +415,48 @@ def getFamily(self): """ return